Fix bug vuejs#1572

lzxb · lzxb · commit d7caf8e57294 · 2017-12-01T14:54:25.000+08:00
diff --git a/examples/index.html b/examples/index.html
@@ -12,6 +12,7 @@ <h1>Vue Router Examples</h1>
     <li><a href="nested-routes">Nested Routes</a></li>
     <li><a href="named-routes">Named Routes</a></li>
     <li><a href="named-views">Named Views</a></li>
+    <li><a href="nameed-change">Nameed Change</a></li>
     <li><a href="route-matching">Route Matching</a></li>
     <li><a href="active-links">Active Links</a></li>
     <li><a href="redirect">Redirect</a></li>
diff --git a/examples/nameed-change/app.js b/examples/nameed-change/app.js
@@ -0,0 +1,72 @@
+import Vue from 'vue'
+import VueRouter from 'vue-router'
+
+Vue.use(VueRouter)
+
+let count = 0
+
+const Home = {
+  template: `
+    <div>
+      <span>nav param:</span>
+      <span class="count" v-text="$route.params.count"></span>
+      <br>
+      <button @click="update()">change param</button>
+
+      <br>
+      <br>
+      <div class="area">
+        <router-link :to="{ name: 'app' }">
+            router-link in Home
+        </router-link>
+
+        <br>
+
+        <nested-component></nested-component>
+      </div>
+    </div>
+  `,
+  methods: {
+    update () {
+      count++
+      this.$router.push({
+        params: {
+          count: count
+        }
+      })
+    }
+  }
+}
+
+Vue.component('nested-component', {
+  template: `
+    <router-link :to="{ name: 'app' }">
+      router-link in NestedComponent
+    </router-link>
+  `
+})
+
+const router = new VueRouter({
+  mode: 'history',
+  routes: [
+    {
+      path: '/nameed-change/:count',
+      name: 'app',
+      component: Home
+    },
+    {
+      path: '*',
+      redirect: { name: 'app', params: { count: 0 }}
+    }
+  ]
+})
+
+new Vue({
+  router,
+  template: `
+    <div id="app">
+      <router-view></router-view>
+    </div>
+  `
+}).$mount('#app')
+
diff --git a/examples/nameed-change/index.html b/examples/nameed-change/index.html
@@ -0,0 +1,6 @@
+<!DOCTYPE html>
+<link rel="stylesheet" href="/global.css">
+<a href="/">&larr; Examples index</a>
+<div id="app"></div>
+<script src="/__build__/shared.js"></script>
+<script src="/__build__/nameed-change.js"></script>
diff --git a/src/components/link.js b/src/components/link.js
@@ -1,6 +1,7 @@
 /* @flow */
 
 import { createRoute, isSameRoute, isIncludedRoute } from '../util/route'
+import { assign } from '../util/location'
 import { _Vue } from '../install'
 
 // work around weird flow bug
@@ -31,7 +32,8 @@ export default {
   render (h: Function) {
     const router = this.$router
     const current = this.$route
-    const { location, route, href } = router.resolve(this.to, current, this.append)
+    const to = typeof this.to === 'string' ? this.to : assign({}, this.to) // Fix bug #1572
+    const { location, route, href } = router.resolve(to, current, this.append)
 
     const classes = {}
     const globalActiveClass = router.options.linkActiveClass
diff --git a/src/util/location.js b/src/util/location.js
@@ -60,7 +60,7 @@ export function normalizeLocation (
   }
 }
 
-function assign (a, b) {
+export function assign (a: Object, b: Object): Object {
   for (const key in b) {
     a[key] = b[key]
   }
diff --git a/test/e2e/specs/nameed-change.js b/test/e2e/specs/nameed-change.js
@@ -0,0 +1,17 @@
+module.exports = {
+  'nameed change': function (browser) {
+    browser
+    .url('http://localhost:8080/nameed-change/')
+      .waitForElementVisible('#app', 1000)
+
+      .assert.urlEquals('http://localhost:8080/nameed-change/0')
+      .assert.containsText('.count', '0')
+      .assert.attributeContains('.area a:nth-child(1)', 'href', '/nameed-change/0')
+      .assert.attributeContains('.area a:nth-child(1)', 'href', '/nameed-change/0')
+      .click('button')
+      .assert.containsText('.count', '1')
+      .assert.attributeContains('.area a:nth-child(1)', 'href', '/nameed-change/1')
+      .assert.attributeContains('.area a:nth-child(1)', 'href', '/nameed-change/1')
+    .end()
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ export function normalizeLocation (`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`
`63`		`-function assign (a, b) {`
	`63`	`+export function assign (a: Object, b: Object): Object {`
`64`	`64`	`for (const key in b) {`
`65`	`65`	`a[key] = b[key]`
`66`	`66`	`}`