Update ESLint config

Author: lydell

.eslintrc.js

@@ -1,21 +1,70 @@
 "use strict";
 
-const baseRules = require("eslint-config-lydell");
+const error = "error";
+const warn = process.argv.includes("--report-unused-disable-directives")
+  ? "error"
+  : "warn";
 
 module.exports = {
   root: true,
-  plugins: ["import", "jest"],
+  extends: ["eslint:recommended"],
+  plugins: ["jest"],
+  parserOptions: {
+    ecmaVersion: 2018,
+  },
   env: { es6: true, node: true },
-  rules: Object.assign({}, baseRules({ import: true }), {
-    "import/order": ["error", { "newlines-between": "always" }],
-    "no-console": "error",
-    "prefer-template": "off",
-  }),
+  rules: {
+    "arrow-body-style": warn,
+    "dot-notation": warn,
+    "no-caller": error,
+    "no-console": warn,
+    "no-eval": error,
+    "no-labels": error,
+    "no-octal-escape": error,
+    "no-param-reassign": error,
+    "no-promise-executor-return": error,
+    "no-restricted-syntax": [
+      error,
+      {
+        selector: "SequenceExpression",
+        message:
+          "The comma operator is confusing and a common mistake. Don’t use it!",
+      },
+    ],
+    "no-self-compare": error,
+    "no-shadow": "error",
+    "no-template-curly-in-string": error,
+    "no-unmodified-loop-condition": error,
+    "no-unneeded-ternary": warn,
+    "no-useless-backreference": error,
+    "no-useless-computed-key": warn,
+    "no-useless-concat": warn,
+    "no-useless-constructor": warn,
+    "no-useless-rename": warn,
+    "no-var": warn,
+    "object-shorthand": warn,
+    "one-var": [warn, "never"],
+    "prefer-arrow-callback": warn,
+    "prefer-const": warn,
+    "prefer-destructuring": [warn, { object: true, array: false }],
+    "prefer-exponentiation-operator": warn,
+    "prefer-numeric-literals": warn,
+    "prefer-object-spread": warn,
+    "prefer-promise-reject-errors": error,
+    "prefer-regex-literals": warn,
+    "prefer-rest-params": warn,
+    "prefer-spread": warn,
+    "prefer-template": warn,
+    curly: warn,
+    eqeqeq: [error, "always", { null: "ignore" }],
+    strict: error,
+    yoda: warn,
+  },
   overrides: [
     {
       files: ["*.test.js"],
-      env: { jest: true },
-      rules: baseRules({ builtin: false, jest: true }),
+      extends: ["plugin:jest/recommended"],
+      env: { "jest/globals": true },
     },
   ],
 };

package-lock.json

@@ -6,15 +6,14 @@
     "prettier": "prettier --write .",
     "eslint": "eslint . --fix",
     "eslint:examples": "eslint --rulesdir src --no-ignore --fix-dry-run --format json --report-unused-disable-directives examples --ext .js,.ts,.vue,.md",
-    "test": "prettier --check . && eslint . && node build.js && jest --coverage"
+    "test": "prettier --check . && eslint . --report-unused-disable-directives && node build.js && jest --coverage"
   },
   "devDependencies": {
     "@typescript-eslint/parser": "4.6.1",
     "babel-eslint": "10.1.0",
     "cross-spawn": "7.0.3",
     "doctoc": "1.4.0",
     "eslint": "7.13.0",
-    "eslint-config-lydell": "14.0.0",
     "eslint-plugin-import": "2.22.1",
     "eslint-plugin-jest": "24.1.0",
     "eslint-plugin-markdown": "1.0.2",

package.json

@@ -287,13 +287,14 @@ function handleLastSemicolon(imports, sourceCode) {
   }
 
   // Preserve the start position, but use the end position of the `from` string.
-  const newLastImport = Object.assign({}, lastImport, {
+  const newLastImport = {
+    ...lastImport,
     range: [lastImport.range[0], nextToLastToken.range[1]],
     loc: {
       start: lastImport.loc.start,
       end: nextToLastToken.loc.end,
     },
-  });
+  };
 
   return imports.slice(0, lastIndex).concat(newLastImport);
 }
@@ -323,9 +324,10 @@ function printSortedSpecifiers(importNode, sourceCode) {
   const specifierTokens = allTokens.slice(openBraceIndex + 1, closeBraceIndex);
   const itemsResult = getSpecifierItems(specifierTokens, sourceCode);
 
-  const items = itemsResult.items.map((originalItem, index) =>
-    Object.assign({}, originalItem, { node: specifiers[index] })
-  );
+  const items = itemsResult.items.map((originalItem, index) => ({
+    ...originalItem,
+    node: specifiers[index],
+  }));
 
   const sortedItems = sortSpecifierItems(items);
 
@@ -679,9 +681,7 @@ function getAllTokens(node, sourceCode) {
   const tokens = sourceCode.getTokens(node);
   const lastTokenIndex = tokens.length - 1;
   return flatMap(tokens, (token, tokenIndex) => {
-    const newToken = Object.assign({}, token, {
-      code: sourceCode.getText(token),
-    });
+    const newToken = { ...token, code: sourceCode.getText(token) };
 
     if (tokenIndex === lastTokenIndex) {
       return [newToken];
@@ -700,7 +700,7 @@ function getAllTokens(node, sourceCode) {
           ...parseWhitespace(
             sourceCode.text.slice(previous.range[1], comment.range[0])
           ),
-          Object.assign({}, comment, { code: sourceCode.getText(comment) }),
+          { ...comment, code: sourceCode.getText(comment) },
         ];
       }),
       ...parseWhitespace(

src/sort.js

@@ -23,7 +23,7 @@ describe("examples", () => {
   for (const item of output) {
     const name = path.basename(item.filePath);
     if (!name.startsWith(".")) {
-      test(name, () => {
+      test(`${name}`, () => {
         expect(item).toMatchObject({
           messages: [],
           errorCount: 0,