Consolidate representation of function calls, remove AggregateExpressionWithFilter, ArraySubquery, ListAgg and ArrayAgg (apache#1247)

Co-authored-by: Andrew Lamb <[email protected]>

Author: 2 people

src/ast/mod.rs

@@ -515,7 +515,7 @@ where
 /// ```
 /// # use sqlparser::parser::Parser;
 /// # use sqlparser::dialect::GenericDialect;
-/// # use sqlparser::ast::{Expr, Function, FunctionArg, FunctionArgExpr, Ident, ObjectName, Value, visit_expressions_mut, visit_statements_mut};
+/// # use sqlparser::ast::*;
 /// # use core::ops::ControlFlow;
 /// let sql = "SELECT x, y FROM t";
 /// let mut statements = Parser::parse_sql(&GenericDialect{}, sql).unwrap();
@@ -525,9 +525,15 @@ where
 ///     let old_expr = std::mem::replace(expr, Expr::Value(Value::Null));
 ///     *expr = Expr::Function(Function {
 ///           name: ObjectName(vec![Ident::new("f")]),
-///           args: vec![FunctionArg::Unnamed(FunctionArgExpr::Expr(old_expr))],
+///           args: FunctionArguments::List(FunctionArgumentList {
+///               duplicate_treatment: None,
+///               args: vec![FunctionArg::Unnamed(FunctionArgExpr::Expr(old_expr))],
+///               clauses: vec![],
+///           }),
 ///           null_treatment: None,
-///           filter: None, over: None, distinct: false, special: false, order_by: vec![],
+///           filter: None,
+///           over: None,
+///           within_group: vec![],
 ///      });
 ///   }
 ///   ControlFlow::<()>::Continue(())

src/ast/visitor.rs

@@ -87,7 +87,6 @@ define_keywords!(
     ARCHIVE,
     ARE,
     ARRAY,
-    ARRAY_AGG,
     ARRAY_MAX_CARDINALITY,
     AS,
     ASC,
@@ -401,7 +400,6 @@ define_keywords!(
     LIKE_REGEX,
     LIMIT,
     LINES,
-    LISTAGG,
     LN,
     LOAD,
     LOCAL,