Skip to content

Commit f73411c

Browse files
committed
Merge remote-tracking branch 'refs/remotes/origin/master' into development
Merge changes to master into development
2 parents 012a311 + 1dc6fc8 commit f73411c

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

README.md

+9-10
Original file line numberDiff line numberDiff line change
@@ -16,33 +16,32 @@ Lets get into those first(the normal front page continues below):
1616

1717
The json-schema-form standard
1818
-----------------------------
19-
A standard, json-schema-form, is being created.
19+
A standard, json-schema-form, is being created.
2020

21-
The reason is that the concept of combining data, JSON Schema and a form definition is something that isn't just usable in a javascript angular web application, but in any framework, on any platform.
22-
Currently, there ports are [angular-schema-form](https://github.com/json-schema-form/angular-schema-form) and [react-schema-form](https://github.com/networknt/react-schema-form), but delphi-schema-form and laravel-schema-form are planned as well.
23-
To make these ports easier to do, and for everything to work in harmony, a common ground has to be established, a [standard](https://github.com/json-schema-form/json-schema-form).
21+
The concept of combining data, JSON Schema and a form definition, is something that isn't just usable in a JavaScript Angular web application, but in any framework, on any platform.
22+
Current ports are [angular-schema-form](https://github.com/json-schema-form/angular-schema-form) and [react-schema-form](https://github.com/networknt/react-schema-form), but delphi-schema-form and laravel-schema-form are planned as well.
23+
To make these ports easier to do, and for everything to work in harmony, a common ground has to be established, a [standard](https://github.com/json-schema-form/json-schema-form).
2424

2525
Organisational
2626
--------------
27-
2827
1. ASF has changed into using a more open governance model. This basically means that ASF is now governed by more people.
2928
2. An umbrella organisaton, json-schema-form, has been formed. As you can see, this repo is now a part of that Github organisation, not Textalk.
3029

3130
Projects
3231
--------
33-
After a phase of planning, the following list of projects has been decided upon:
32+
After a phase of planning, the following list of projects has been decided upon:
3433
https://github.com/json-schema-form/json-schema-form/wiki/Current-projects
3534

3635
Release 1.0
3736
-----------
38-
The next major release of ASF will be 1.0.
37+
The next major release of ASF will be 1.0.
3938

40-
The goal for that version is to include the breaking changes that is needed for future developents, like *Of and local $refs:
39+
The goal for that version is to include the breaking changes that is needed for future developments, like *Of and local $refs:
4140

4241
* Break out the non-framework specific parts of ASF into a vanilla ES6 module
4342
* Remove the built-in bootstrap decorator, and in doing that require that users wanting to use that load that separately. The reason obviously being the material decorator.
4443

45-
The reason for the core break out is for all javascript-based ports of the json-schema-form concept to be able to share the same central code base.
44+
The reason for the core break out is for all javascript-based ports of the json-schema-form concept to be able to share the same central code base.
4645
Work in that direction is being done in the [json-schema-form-core](https://github.com/json-schema-form/json-schema-form-core) repository.
4746

4847
Schema builder UI
@@ -62,7 +61,7 @@ The documentation is evolving, and it is happening mostly on the wiki:
6261
* [The ASF wiki](https://github.com/json-schema-form/angular-schema-form/wiki)
6362
* [The wiki of the json-schema-form organisation](https://github.com/json-schema-form/json-schema-form/wiki)
6463

65-
New gitter rooms
64+
New Gitter rooms
6665
----------------
6766
These are just started.
6867
* Discussions on the [general json-schema-form projects being carried out](https://gitter.im/json-schema-form/json-schema-form-projects)

src/directives/schema-validate.js

+10-2
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,13 @@ angular.module('schemaForm').directive('schemaValidate', ['sfValidator', '$parse
106106
var schema = form.schema;
107107

108108
// A bit ugly but useful.
109-
scope.validateField = function() {
109+
scope.validateField = function(formName) {
110+
111+
// If we have specified a form name, and this model is not within
112+
// that form, then leave things be.
113+
if(formName != undefined && ngModel.$$parentForm.$name !== formName) {
114+
return;
115+
}
110116

111117
// Special case: arrays
112118
// TODO: Can this be generalized in a way that works consistently?
@@ -153,7 +159,9 @@ angular.module('schemaForm').directive('schemaValidate', ['sfValidator', '$parse
153159
});
154160

155161
// Listen to an event so we can validate the input on request
156-
scope.$on('schemaFormValidate', scope.validateField);
162+
scope.$on('schemaFormValidate', function(event, formName) {
163+
scope.validateField(formName);
164+
});
157165

158166
scope.schemaError = function() {
159167
return error;

0 commit comments

Comments
 (0)