BUG: DateTimeConverter typo calls np._asarray_tuplesafe. TST: a few more test cases for DateTimeConverter.convert

Author: changhiskhan

pandas/tseries/converter.py

@@ -137,7 +137,6 @@ class DatetimeConverter(dates.DateConverter):
 
     @staticmethod
     def convert(values, unit, axis):
-        from pandas.tseries.index import DatetimeIndex
         def try_parse(values):
             try:
                 return _dt_to_float_ordinal(tools.to_datetime(values))
@@ -154,7 +153,7 @@ def try_parse(values):
             return try_parse(values)
         elif isinstance(values, (list, tuple, np.ndarray)):
             if not isinstance(values, np.ndarray):
-                values = np._asarray_tuplesafe(values)
+                values = com._asarray_tuplesafe(values)
 
             if com.is_integer_dtype(values) or com.is_float_dtype(values):
                 return values

pandas/tseries/tests/test_converter.py

@@ -1,4 +1,4 @@
-from datetime import datetime, time, timedelta
+from datetime import datetime, time, timedelta, date
 import sys
 import os
 import unittest
@@ -25,6 +25,25 @@ def test_convert_accepts_unicode(self):
         r2 = self.dtc.convert(u"12:22",None,None)
         assert(r1==r2), "DatetimeConverter.convert should accept unicode"
 
+    def test_conversion(self):
+        rs = self.dtc.convert(['2012-1-1'], None, None)[0]
+        xp = datetime(2012, 1, 1).toordinal()
+        self.assertEqual(rs, xp)
+
+        rs = self.dtc.convert('2012-1-1', None, None)
+        self.assertEqual(rs, xp)
+
+        rs = self.dtc.convert(date(2012, 1, 1), None, None)
+        self.assertEqual(rs, xp)
+
+        rs = self.dtc.convert(datetime(2012, 1, 1).toordinal(), None, None)
+        self.assertEqual(rs, xp)
+
+        rs = self.dtc.convert('2012-1-1', None, None)
+        self.assertEqual(rs, xp)
+
+
+
 if __name__ == '__main__':
     import nose
     nose.runmodule(argv=[__file__,'-vvs','-x','--pdb', '--pdb-failure'],