Skip to content

Commit fb13dcf

Browse files
fhahnfhahn
committed
[ConstraintElim] Enable pass by default.
The pass should help to close a functional gap when it comes to reasoning about related conditions in a relatively general way. It addresses multiple existing issues (linked below) and the need for a more powerful reasoning system was also discussed recently in https://discourse.llvm.org/t/rfc-alternative-approach-of-dealing-with-implications-from-comparisons-through-pos-analysis/65601/7 On AArch64, the new pass performs ~2000 simplifications on MultiSource,SPEC2006,SPEC2017 with -O3. Compile-time impact: NewPM-O3: +0.20% NewPM-ReleaseThinLTO: +0.32% NewPM-ReleaseLTO-g: +0.28% https://llvm-compile-time-tracker.com/compare.php?from=f01a3a893c147c1594b9a3fbd817456b209dabbf&to=577688758ef64fb044215ec3e497ea901bb2db28&stat=instructions:u Fixes #49344. Fixes #47888. Fixes #48253. Fixes #49229. Fixes #58074. Reviewed By: asbirlea Differential Revision: https://reviews.llvm.org/D135915
1 parent e568d00 commit fb13dcf

8 files changed

+8
-1
lines changed

‎llvm/lib/Passes/PassBuilderPipelines.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ static cl::opt<bool>
263263
cl::desc("Enable lowering of the matrix intrinsics"));
264264

265265
static cl::opt<bool> EnableConstraintElimination(
266-
"enable-constraint-elimination", cl::init(false), cl::Hidden,
266+
"enable-constraint-elimination", cl::init(true), cl::Hidden,
267267
cl::desc(
268268
"Enable pass to eliminate conditions based on linear constraints"));
269269

‎llvm/test/Other/new-pm-defaults.ll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@
154154
; CHECK-O-NEXT: Running pass: SimplifyCFGPass
155155
; CHECK-O-NEXT: Running pass: InstCombinePass
156156
; CHECK-O3-NEXT: AggressiveInstCombinePass
157+
; CHECK-O23SZ-NEXT: Running pass: ConstraintEliminationPass
157158
; CHECK-O1-NEXT: Running pass: LibCallsShrinkWrapPass
158159
; CHECK-O2-NEXT: Running pass: LibCallsShrinkWrapPass
159160
; CHECK-O3-NEXT: Running pass: LibCallsShrinkWrapPass

‎llvm/test/Other/new-pm-lto-defaults.ll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@
8989
; CHECK-O23SZ-NEXT: Running pass: DeadArgumentEliminationPass
9090
; CHECK-O23SZ-NEXT: Running pass: InstCombinePass
9191
; CHECK-EP-Peephole-NEXT: Running pass: NoOpFunctionPass
92+
; CHECK-O23SZ-NEXT: Running pass: ConstraintEliminationPass
9293
; CHECK-O23SZ-NEXT: Running pass: JumpThreadingPass
9394
; CHECK-O23SZ-NEXT: Running analysis: LazyValueAnalysis
9495
; CHECK-O23SZ-NEXT: Running pass: SROAPass on foo

‎llvm/test/Other/new-pm-thinlto-defaults.ll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@
130130
; CHECK-O-NEXT: Running pass: SimplifyCFGPass
131131
; CHECK-O-NEXT: Running pass: InstCombinePass
132132
; CHECK-O3-NEXT: Running pass: AggressiveInstCombinePass
133+
; CHECK-O23SZ-NEXT: Running pass: ConstraintEliminationPass
133134
; CHECK-O1-NEXT: Running pass: LibCallsShrinkWrapPass
134135
; CHECK-O2-NEXT: Running pass: LibCallsShrinkWrapPass
135136
; CHECK-O3-NEXT: Running pass: LibCallsShrinkWrapPass

‎llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
; CHECK-O-NEXT: Running pass: SimplifyCFGPass
9393
; CHECK-O-NEXT: Running pass: InstCombinePass
9494
; CHECK-O3-NEXT: Running pass: AggressiveInstCombinePass
95+
; CHECK-O23SZ-NEXT: Running pass: ConstraintEliminationPass
9596
; CHECK-O1-NEXT: Running pass: LibCallsShrinkWrapPass
9697
; CHECK-O2-NEXT: Running pass: LibCallsShrinkWrapPass
9798
; CHECK-O3-NEXT: Running pass: LibCallsShrinkWrapPass

‎llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@
101101
; CHECK-O-NEXT: Running pass: SimplifyCFGPass
102102
; CHECK-O-NEXT: Running pass: InstCombinePass
103103
; CHECK-O3-NEXT: Running pass: AggressiveInstCombinePass
104+
; CHECK-O23SZ-NEXT: Running pass: ConstraintEliminationPass
104105
; CHECK-O1-NEXT: Running pass: LibCallsShrinkWrapPass
105106
; CHECK-O2-NEXT: Running pass: LibCallsShrinkWrapPass
106107
; CHECK-O3-NEXT: Running pass: LibCallsShrinkWrapPass

‎llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@
128128
; CHECK-O-DAG: Running analysis: BranchProbabilityAnalysis on foo
129129
; CHECK-O-DAG: Running analysis: PostDominatorTreeAnalysis on foo
130130
; CHECK-O3-NEXT: Running pass: AggressiveInstCombinePass
131+
; CHECK-O23SZ-NEXT: Running pass: ConstraintEliminationPass
131132
; CHECK-O1-NEXT: Running pass: LibCallsShrinkWrapPass
132133
; CHECK-O2-NEXT: Running pass: LibCallsShrinkWrapPass
133134
; CHECK-O3-NEXT: Running pass: LibCallsShrinkWrapPass

‎llvm/test/Other/new-pm-thinlto-prelink-samplepgo-defaults.ll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@
9696
; CHECK-O-NEXT: Running pass: SimplifyCFGPass
9797
; CHECK-O-NEXT: Running pass: InstCombinePass
9898
; CHECK-O3-NEXT: Running pass: AggressiveInstCombinePass
99+
; CHECK-O23SZ-NEXT: Running pass: ConstraintEliminationPass
99100
; CHECK-O1-NEXT: Running pass: LibCallsShrinkWrapPass
100101
; CHECK-O2-NEXT: Running pass: LibCallsShrinkWrapPass
101102
; CHECK-O3-NEXT: Running pass: LibCallsShrinkWrapPass

0 commit comments

Comments
 (0)