Skip to content

Commit c35761d

Browse files
committed
[GlobalISel] Bail on G_PHI narrowing of odd types (PR48188)
The current narrowing code for G_PHI can only handle the case where the size is a multiple of the narrow size. If this is not the case, fall back to SDAG instead of asserting. Original patch by shepmaster. Differential Revision: https://reviews.llvm.org/D92446
1 parent 9ecbb34 commit c35761d

File tree

2 files changed

+32
-0
lines changed

2 files changed

+32
-0
lines changed

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1006,6 +1006,11 @@ LegalizerHelper::LegalizeResult LegalizerHelper::narrowScalar(MachineInstr &MI,
10061006
Observer.changedInstr(MI);
10071007
return Legalized;
10081008
case TargetOpcode::G_PHI: {
1009+
// FIXME: add support for when SizeOp0 isn't an exact multiple of
1010+
// NarrowSize.
1011+
if (SizeOp0 % NarrowSize != 0)
1012+
return UnableToLegalize;
1013+
10091014
unsigned NumParts = SizeOp0 / NarrowSize;
10101015
SmallVector<Register, 2> DstRegs(NumParts);
10111016
SmallVector<SmallVector<Register, 2>, 2> SrcRegs(MI.getNumOperands() / 2);

llvm/test/CodeGen/AArch64/pr48188.ll

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
2+
; RUN: llc -O0 -mtriple=aarch64-unknown-linux-gnu < %s | FileCheck %s
3+
4+
; GlobalISel cannot legalize this phi, so we fall back to SDAG.
5+
define void @test() nounwind {
6+
; CHECK-LABEL: test:
7+
; CHECK: // %bb.0: // %entry
8+
; CHECK-NEXT: sub sp, sp, #16 // =16
9+
; CHECK-NEXT: mov x1, xzr
10+
; CHECK-NEXT: mov x0, x1
11+
; CHECK-NEXT: str x1, [sp] // 8-byte Folded Spill
12+
; CHECK-NEXT: str x0, [sp, #8] // 8-byte Folded Spill
13+
; CHECK-NEXT: b .LBB0_1
14+
; CHECK-NEXT: .LBB0_1: // %loop
15+
; CHECK-NEXT: // =>This Inner Loop Header: Depth=1
16+
; CHECK-NEXT: ldr x0, [sp, #8] // 8-byte Folded Reload
17+
; CHECK-NEXT: ldr x1, [sp] // 8-byte Folded Reload
18+
; CHECK-NEXT: str x1, [sp] // 8-byte Folded Spill
19+
; CHECK-NEXT: str x0, [sp, #8] // 8-byte Folded Spill
20+
; CHECK-NEXT: b .LBB0_1
21+
entry:
22+
br label %loop
23+
24+
loop:
25+
%p = phi i72 [ 0, %entry ], [ %p, %loop ]
26+
br label %loop
27+
}

0 commit comments

Comments
 (0)