Skip to content

Commit c07fcd4

Browse files
ManuelvOKManuel Kalettka
authored andcommitted
[Coverage] Map regions from system headers (#76950)
In 2155195, the "system-headers-coverage" option has been added but not used in all necessary places. This is the recommit since it has been reverted in faef68b Potential reviewers: @gulfemsavrun @petrhosek Co-authored-by: Manuel Kalettka <[email protected]>
1 parent a792cb6 commit c07fcd4

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

clang/lib/CodeGen/CodeGenPGO.cpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ static llvm::cl::opt<bool>
2828
llvm::cl::desc("Enable value profiling"),
2929
llvm::cl::Hidden, llvm::cl::init(false));
3030

31+
extern llvm::cl::opt<bool> SystemHeadersCoverage;
32+
3133
using namespace clang;
3234
using namespace CodeGen;
3335

@@ -1022,7 +1024,7 @@ bool CodeGenPGO::skipRegionMappingForDecl(const Decl *D) {
10221024
// Don't map the functions in system headers.
10231025
const auto &SM = CGM.getContext().getSourceManager();
10241026
auto Loc = D->getBody()->getBeginLoc();
1025-
return SM.isInSystemHeader(Loc);
1027+
return !SystemHeadersCoverage && SM.isInSystemHeader(Loc);
10261028
}
10271029

10281030
void CodeGenPGO::emitCounterRegionMapping(const Decl *D) {

clang/lib/CodeGen/CoverageMappingGen.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ static llvm::cl::opt<bool> EmptyLineCommentCoverage(
3737
"disable it on test)"),
3838
llvm::cl::init(true), llvm::cl::Hidden);
3939

40-
static llvm::cl::opt<bool> SystemHeadersCoverage(
40+
llvm::cl::opt<bool> SystemHeadersCoverage(
4141
"system-headers-coverage",
4242
llvm::cl::desc("Enable collecting coverage from system headers"),
4343
llvm::cl::init(false), llvm::cl::Hidden);

0 commit comments

Comments
 (0)