Skip to content

Commit 2132906

Browse files
committed
Revert "[MLIR] Add forgotten directory Support to unittests cmake"
This reverts commit 0c553cc. This caused a buildbot failure (https://lab.llvm.org/buildbot#builders/197/builds/888). ``` ******************** TEST 'ScudoStandalone-Unit :: ./ScudoUnitTest-aarch64-Test/ScudoCommonTest.ResidentMemorySize' FAILED ******************** Script: -- /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/projects/compiler-rt/lib/scudo/standalone/tests/./ScudoUnitTest-aarch64-Test --gtest_filter=ScudoCommonTest.ResidentMemorySize -- Note: Google Test filter = ScudoCommonTest.ResidentMemorySize [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from ScudoCommonTest [ RUN ] ScudoCommonTest.ResidentMemorySize /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/compiler-rt/lib/scudo/standalone/tests/common_test.cpp:49: Failure Expected: (getResidentMemorySize()) > (OnStart + Size - Threshold), actual: 707358720 vs 943153152 [ FAILED ] ScudoCommonTest.ResidentMemorySize (21709 ms) [----------] 1 test from ScudoCommonTest (21709 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (21709 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ScudoCommonTest.ResidentMemorySize 1 FAILED TEST ******************** ```
1 parent aabe901 commit 2132906

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

mlir/include/mlir/Support/DebugAction.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,8 @@ template <typename... ParameterTs> class DebugAction {
205205

206206
/// Provide classof to allow casting between handler types.
207207
static bool classof(const DebugActionManager::HandlerBase *handler) {
208-
return handler->getHandlerID() == TypeID::get<Handler>();
208+
return handler->getHandlerID() ==
209+
TypeID::get<DebugAction<ParameterTs...>::Handler>();
209210
}
210211
};
211212

mlir/unittests/CMakeLists.txt

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ add_subdirectory(ExecutionEngine)
1111
add_subdirectory(Interfaces)
1212
add_subdirectory(IR)
1313
add_subdirectory(Pass)
14-
add_subdirectory(Support)
1514
add_subdirectory(Rewrite)
1615
add_subdirectory(TableGen)
1716
add_subdirectory(Transforms)

mlir/unittests/Support/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ add_mlir_unittest(MLIRSupportTests
77
)
88

99
target_link_libraries(MLIRSupportTests
10-
PRIVATE MLIRSupport)
10+
PRIVATE MLIRSupportIndentedOstream MLIRSupport)

0 commit comments

Comments
 (0)