Skip to content
This repository was archived by the owner on Apr 23, 2020. It is now read-only.

Commit 1955731

Browse files
committed
Fix PR35739: chkstk and chkst2 should only be built for Windows
As reported in PR35739, rL252927 added the Windows specific chkstk and chkstk2 sources unconditionally, and since these are assembly without a NO_EXEC_STACK_DIRECTIVE at the end, automated vulnerability scanners warned about the objects having an executable stack. Avoid the problem by only including these files when Windows is targeted. Reviewers: compnerd, rnk, martell Reviewed By: martell Subscribers: mstorsjo, mgorny, martell, javed.absar, #sanitizers, llvm-commits Differential Revision: https://reviews.llvm.org/D41567 git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@321431 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent d862334 commit 1955731

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

lib/builtins/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,6 @@ set(x86_ARCH_SOURCES
232232

233233
if (NOT MSVC)
234234
set(x86_64_SOURCES
235-
x86_64/chkstk.S
236-
x86_64/chkstk2.S
237235
x86_64/floatdidf.c
238236
x86_64/floatdisf.c
239237
x86_64/floatdixf.c
@@ -253,8 +251,6 @@ if (NOT MSVC)
253251
set(i386_SOURCES
254252
i386/ashldi3.S
255253
i386/ashrdi3.S
256-
i386/chkstk.S
257-
i386/chkstk2.S
258254
i386/divdi3.S
259255
i386/floatdidf.S
260256
i386/floatdisf.S

0 commit comments

Comments
 (0)