Skip to content

Commit 5d980ce

Browse files
committed
Update: add whatsnew entry and comments in pandas/tests/arrays/boolean/test_reduction.py based on change suggestions related to issue pandas-dev#33253
1 parent 81860e3 commit 5d980ce

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

doc/source/whatsnew/v1.1.0.rst

+1-2
Original file line numberDiff line numberDiff line change
@@ -369,8 +369,7 @@ Missing
369369
^^^^^^^
370370

371371
- Calling :meth:`fillna` on an empty Series now correctly returns a shallow copied object. The behaviour is now consistent with :class:`Index`, :class:`DataFrame` and a non-empty :class:`Series` (:issue:`32543`).
372-
- Bug in :meth:`array.any` incorrectly returns ``<NA>`` for pandas.array of all ``False`` value, e.g. ``pd.array([False, False], dtype="boolean")``. Now it returns ``False`` (:issue:`33253`)
373-
- Bug in :meth:`array.all` incorrectly returns ``<NA>`` for pandas.array of all ``True`` value, e.g. ``pd.array([True, True], dtype="boolean")``. Now it returns ``True``(:issue:`33253`)
372+
- Bug in :meth:`~Series.any` and :meth:`~Series.all` incorrectly returning ``<NA>`` for all ``False`` or all ``True`` values using the nulllable boolean dtype and with ``skipna=False`` (:issue:`33253`)
374373

375374
MultiIndex
376375
^^^^^^^^^^

pandas/tests/arrays/boolean/test_reduction.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ def data():
1212
)
1313

1414

15-
# .any(), .all() returns <NA> for [False, False], [True, True], GH-33253.
1615
@pytest.mark.parametrize(
1716
"values, exp_any, exp_all, exp_any_noskip, exp_all_noskip",
1817
[
1918
([True, pd.NA], True, True, True, pd.NA),
2019
([False, pd.NA], False, False, pd.NA, False),
2120
([pd.NA], False, True, pd.NA, pd.NA),
2221
([], False, True, False, True),
22+
# GH-33253: all True / all False values buggy with skipna=False
2323
([True, True], True, True, True, True),
2424
([False, False], False, False, False, False),
2525
],

0 commit comments

Comments
 (0)