Skip to content

Commit 61787b3

Browse files
committed
Fix ICE with nested macro_rules!-style macros
Fixes rust-lang#10536.
1 parent efebeec commit 61787b3

File tree

2 files changed

+36
-2
lines changed

2 files changed

+36
-2
lines changed

src/libsyntax/parse/parser.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3243,7 +3243,7 @@ impl<'a> Parser<'a> {
32433243
None => {
32443244
// we only expect an ident if we didn't parse one
32453245
// above.
3246-
let ident_str = if id == token::special_idents::invalid {
3246+
let ident_str = if id.name == token::special_idents::invalid.name {
32473247
"identifier, "
32483248
} else {
32493249
""
@@ -3263,7 +3263,7 @@ impl<'a> Parser<'a> {
32633263
);
32643264
let hi = self.span.hi;
32653265

3266-
if id == token::special_idents::invalid {
3266+
if id.name == token::special_idents::invalid.name {
32673267
return box(GC) spanned(lo, hi, StmtMac(
32683268
spanned(lo, hi, MacInvocTT(pth, tts, EMPTY_CTXT)), false));
32693269
} else {

src/test/compile-fail/issue-10536.rs

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
// We only want to assert that this doesn't ICE, we don't particularly care
12+
// about whether it nor it fails to compile.
13+
14+
// error-pattern:
15+
16+
#![feature(macro_rules)]
17+
18+
macro_rules! foo{
19+
() => {{
20+
macro_rules! bar{() => (())}
21+
1
22+
}}
23+
}
24+
25+
pub fn main() {
26+
foo!();
27+
28+
assert!({one! two()});
29+
30+
// regardless of whether nested macro_rules works, the following should at
31+
// least throw a conventional error.
32+
assert!({one! two});
33+
}
34+

0 commit comments

Comments
 (0)