Skip to content

Adding the collection rewrites #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dwijnand opened this issue May 9, 2019 · 3 comments
Closed

Adding the collection rewrites #3

dwijnand opened this issue May 9, 2019 · 3 comments

Comments

@dwijnand
Copy link
Collaborator

dwijnand commented May 9, 2019

https://github.com/scala/scala-collection-compat also contains the Scalafix rewrites for the Scala 2.13 collections.

@julienrf, @szeiger mentioned that perhaps these two should merge. I don't have any problem merging in any direction, but I propose that:

  • I transfer this repo to the scala org, and
  • I/we merge in a filter-branch of the collection rewrites

WDYT?

@julienrf
Copy link
Collaborator

julienrf commented May 9, 2019

That looks good!

@dwijnand
Copy link
Collaborator Author

@lrytz ping me when you're back and let's chat about this.

I started doing this (https://github.com/dwijnand/scala-rewrites/tree/merge-in-collection-rewrites), but the rewrites are written in terms of the scala.collection.compat library, so maybe it makes more sense to merge this repo into scala-collection-compat (and rename it).

Also, btw, those rewrites are available as "org.scala-lang.modules" %% "scala-collection-migrations" % "2.0.0"!

@dwijnand
Copy link
Collaborator Author

I feel like we missed the boat on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants