Skip to content

Commit e012bb5

Browse files
committed
refdb_backend: fix reflog support shim
1 parent f445fe9 commit e012bb5

File tree

1 file changed

+5
-20
lines changed

1 file changed

+5
-20
lines changed

src/refdb_backend.c

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@ pygit2_refdb_backend_lookup(git_reference **out,
198198

199199
*out = result->reference;
200200
out:
201-
Py_DECREF(result);
202201
return err;
203202
}
204203

@@ -451,25 +450,11 @@ RefdbBackend_init(RefdbBackend *self, PyObject *args, PyObject *kwds)
451450
be->backend.ensure_log = pygit2_refdb_backend_ensure_log;
452451
}
453452

454-
if (PyObject_HasAttrString((PyObject *)self, "reflog_read")) {
455-
be->reflog_read = PyObject_GetAttrString((PyObject *)self, "reflog_read");
456-
be->backend.reflog_read = pygit2_refdb_backend_reflog_read;
457-
}
458-
459-
if (PyObject_HasAttrString((PyObject *)self, "reflog_write")) {
460-
be->reflog_write = PyObject_GetAttrString((PyObject *)self, "reflog_write");
461-
be->backend.reflog_write = pygit2_refdb_backend_reflog_write;
462-
}
463-
464-
if (PyObject_HasAttrString((PyObject *)self, "reflog_rename")) {
465-
be->reflog_rename = PyObject_GetAttrString((PyObject *)self, "reflog_rename");
466-
be->backend.reflog_rename = pygit2_refdb_backend_reflog_rename;
467-
}
468-
469-
if (PyObject_HasAttrString((PyObject *)self, "reflog_delete")) {
470-
be->reflog_delete = PyObject_GetAttrString((PyObject *)self, "reflog_delete");
471-
be->backend.reflog_delete = pygit2_refdb_backend_reflog_delete;
472-
}
453+
/* TODO: First-class reflog support */
454+
be->backend.reflog_read = pygit2_refdb_backend_reflog_read;
455+
be->backend.reflog_write = pygit2_refdb_backend_reflog_write;
456+
be->backend.reflog_rename = pygit2_refdb_backend_reflog_rename;
457+
be->backend.reflog_delete = pygit2_refdb_backend_reflog_delete;
473458

474459
/* TODO: transactions
475460
if (PyObject_HasAttrString((PyObject *)self, "lock")) {

0 commit comments

Comments
 (0)