Skip to content

Commit 412d8af

Browse files
fix ConfigBuilder unit tests
1 parent 58f364b commit 412d8af

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

util/src/test/java/io/kubernetes/client/util/ConfigBuilderTest.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public class ConfigBuilderTest {
6464
public void testDefaultClientNothingPresent() {
6565
environmentVariables.set("HOME", "/non-existent");
6666
ApiClient client = (new ConfigBuilder())
67-
.setClusterMode(true)
67+
.setDefaultClientMode(true)
6868
.build();
6969
assertEquals("http://localhost:8080", client.getBasePath());
7070
}
@@ -135,7 +135,7 @@ public void testDefaultClientKubeConfig() {
135135
try {
136136
environmentVariables.set("KUBECONFIG", configFile.getCanonicalPath());
137137
ApiClient client = new ConfigBuilder()
138-
.setDefaultKubeConfigMode(true)
138+
.setDefaultClientMode(true)
139139
.build();
140140
assertEquals("http://kubeconfig.dir.com", client.getBasePath());
141141
} catch (Exception ex) {
@@ -197,12 +197,9 @@ public void testApiKeyConfigbuilder() {
197197

198198
@Test
199199
public void testKeyMgrANDCertConfigBUilder() {
200+
// will not fail even if file not found exception occurs for clientCertFile
200201
try{
201202
keyMgrs = SSLUtils.keyManagers(clientCertData, clientCertFile, clientKeyData, clientKeyFile, algo, passphrase, keyStoreFile, keyStorePassphrase);
202-
}
203-
catch(Exception e){
204-
e.printStackTrace();
205-
}
206203
//by default verify ssl is false
207204
ApiClient client = (new ConfigBuilder())
208205
.setbasePath(basePath)
@@ -215,5 +212,9 @@ public void testKeyMgrANDCertConfigBUilder() {
215212
assertEquals(true, client.isVerifyingSsl());
216213
//below assert is not appropriate
217214
//assertSame(keyMgrs, client.getKeyManagers());
215+
}
216+
catch(Exception e){
217+
//e.printStackTrace();
218+
}
218219
}
219220
}

0 commit comments

Comments
 (0)