Merge pull request #1 from ashawley/fix-35-out-of-memory

Fix 35 out of memory

Author: lespea

src/main/scala/scala/xml/parsing/MarkupParserCommon.scala

@@ -63,7 +63,7 @@ private[scala] trait MarkupParserCommon extends TokenTests {
    */
   def xAttributeValue(endCh: Char): String = {
     val buf = new StringBuilder
-    while (ch != endCh) {
+    while (ch != endCh && !eof) {
       // well-formedness constraint
       if (ch == '<') return errorAndResult("'<' not allowed in attrib value", "")
       else if (ch == SU) truncatedError("")

src/test/scala/scala/xml/XMLTest.scala

@@ -838,6 +838,12 @@ expected closing tag of foo
     assertEquals("""<x:foo xmlns:x="gaga"/>""", pp.format(x))
   }
 
+  @UnitTest( expected = classOf[scala.xml.SAXParseException] )
+  def issue35: Unit = {
+    val broken = "<broken attribute='is truncated"
+    XML.loadString(broken)
+  }
+
   @UnitTest
   def nodeSeqNs: Unit = {
     val x = {

src/test/scala/scala/xml/pull/XMLEventReaderTest.scala

@@ -1,4 +1,5 @@
-package scala.xml.pull
+package scala.xml
+package pull
 
 import org.junit.Test
 import org.junit.Ignore
@@ -40,6 +41,17 @@ class XMLEventReaderTest {
     er.stop  // allow thread to be garbage-collected
   }
 
+  @Test
+  def issue35: Unit = {
+    val broken = "<broken attribute='is truncated"
+    val x = new Source {
+      val iter = broken.iterator
+      override def reportError(pos: Int, msg: String, out: java.io.PrintStream = Console.err) {}
+    }
+    val r = new XMLEventReader(x)
+    assertTrue(r.next.isInstanceOf[EvElemStart])
+  }
+
  @Test(expected = classOf[Exception]) 
  def missingTagTest: Unit = {
    val data=