feat: add zero linter

Implements golangci#3491.

Author: leonklingele

.golangci.reference.yml

@@ -2096,6 +2096,7 @@ linters:
     - whitespace
     - wrapcheck
     - wsl
+    - zero
 
   # Enable all available linters.
   # Default: false
@@ -2206,6 +2207,7 @@ linters:
     - whitespace
     - wrapcheck
     - wsl
+    - zero
 
   # Enable presets.
   # https://golangci-lint.run/usage/linters

go.mod

@@ -45,6 +45,7 @@ require (
 	github.com/gordonklaus/ineffassign v0.0.0-20210914165742-4cc7213b9bc8
 	github.com/gostaticanalysis/forcetypeassert v0.1.0
 	github.com/gostaticanalysis/nilerr v0.1.1
+	github.com/gostaticanalysis/zero v0.1.0
 	github.com/hashicorp/go-multierror v1.1.1
 	github.com/hashicorp/go-version v1.6.0
 	github.com/hexops/gotextdiff v1.0.3

go.sum

@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"github.com/gostaticanalysis/zero"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewZero() *goanalysis.Linter {
+	a := zero.Analyzer
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/golinters/zero.go

@@ -872,6 +872,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/bombsimon/wsl"),
 
+		linter.NewConfig(golinters.NewZero()).
+			WithSince("v1.51.0").
+			WithPresets(linter.PresetBugs).
+			WithURL("https://github.com/gostaticanalysis/zero"),
+
 		// nolintlint must be last because it looks at the results of all the previous linters for unused nolint directives
 		linter.NewConfig(golinters.NewNoLintLint(noLintLintCfg)).
 			WithSince("v1.26.0").

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,35 @@
+//golangcitest:args -Ezero
+package testdata
+
+var _ string = "" // want "shoud not assign zero value"
+
+func _() {
+	n := 0 // want "shoud not assign zero value"
+	_ = n
+
+	var _ []int = nil     // want "shoud not assign zero value"
+	var _ []int = []int{} // OK
+	m := int32(0)         // OK
+	_ = m
+	var _ *int = nil            // want "shoud not assign zero value"
+	var _ struct{} = struct{}{} // want "shoud not assign zero value"
+	var _, _ int                // OK
+	var _, _ int = 0, 1         // want "shoud not assign zero value"
+	var _, _ int = 1, 2         // OK
+	var _, _ int = 1 - 1, 2 - 2 // want "shoud not assign zero value"
+	var _ bool = false          // want "shoud not assign zero value"
+	var _ bool = true           // OK
+
+	type T struct{ N int }
+	var _ T = T{} // want "shoud not assign zero value"
+
+	{
+		n, _ := func() (int, int) { return 0, 0 }() // OK
+		_ = n
+	}
+
+	{
+		var n, _ = func() (int, int) { return 0, 0 }() // OK
+		_ = n
+	}
+}