android and ios API unification

Author: PeterStaev

README.md

@@ -1,8 +1,6 @@
 # NativeScript-PullToRefresh :recycle:
 NativeScript plugin to use Pull to Refresh on any view. 
 
-**Android Only - PRs welcome for iOS**.
-
 #### [Android SwipeRefreshLayout](http://developer.android.com/reference/android/support/v4/widget/SwipeRefreshLayout.html)
 ##### [Material Design Indicators Spec](https://www.google.com/design/spec/components/progress-activity.html#progress-activity-types-of-indicators)
 
@@ -44,14 +42,14 @@ function refreshList(args) {
     // Get reference to the PullToRefresh;
     var pullRefresh = args.object;
 
-    // Do work here... and when done call .setRefreshing(false) to stop the refreshing
+    // Do work here... and when done call set refreshing property to false to stop the refreshing
     loadItems().then(function (resp) {
         // ONLY USING A TIMEOUT TO SIMULATE/SHOW OFF THE REFRESHING
         setTimeout(function () {
-            pullRefresh.setRefreshing(false);
+            pullRefresh.refreshing = false;
         }, 1000);
     }, function (err) {
-        pullRefresh.setRefreshing(false);
+        pullRefresh.refreshing = false;
     });
 }
 exports.refreshList = refreshList;
@@ -63,6 +61,6 @@ exports.refreshList = refreshList;
 
 ## API
 
-### setRefreshing
+### refreshing
 
-Notifies the widget that the refresh state has changed.
+Property. Notifies the widget that the refresh state has changed.

demo/app/main-page.js

@@ -2,8 +2,8 @@ var app = require("application");
 var Observable = require("data/observable").Observable;
 var ObservableArray = require("data/observable-array").ObservableArray;
 var platformModule = require("platform");
-var color = require("color");
-
+var color = require("color");
+
 var users = [
     { name: 'Billy Bob' },
     { name: 'Tweeder' },
@@ -16,21 +16,21 @@ var users = [
 ];
 var viewModel = new Observable({
     users: new ObservableArray(users)
-});
-
-function pageLoaded(args) {
-    var page = args.object;
+});
+
+function pageLoaded(args) {
+    var page = args.object;
     // Change statusbar color on Lollipop
-
+
     if (app.android && platformModule.device.sdkVersion >= "21") {
         var window = app.android.startActivity.getWindow();
         window.setStatusBarColor(new color.Color("#1976D2").android);
-    }
-    page.bindingContext = viewModel; 
-    loadItems();
-}
-exports.pageLoaded = pageLoaded;
-
+    }
+    page.bindingContext = viewModel; 
+    loadItems();
+}
+exports.pageLoaded = pageLoaded;
+
 function loadItems() {
     return new Promise(function (resolve, reject) {
         try { 
@@ -44,8 +44,8 @@ function loadItems() {
             reject(ex);
         }
     });
-}
-
+}
+
 function refreshList(args) {
 
     var pullRefresh = args.object;
@@ -54,16 +54,16 @@ function refreshList(args) {
         console.log(response);
         // ONLY USING A TIMEOUT TO SIMULATE/SHOW OFF THE REFRESHING
         setTimeout(function () {
-            pullRefresh.setRefreshing(false);
+            pullRefresh.refreshing = false;
         }, 1000);
     }, function (err) {
-        pullRefresh.setRefreshing(false);
+        pullRefresh.refreshing = false;
         alert(err);
     });
-}
-exports.refreshList = refreshList;
-
-
+}
+exports.refreshList = refreshList;
+
+
 
 Number.prototype.times = function (func) {
     for (var i = 0; i < Number(this) ; i++) {

package.json

@@ -1,11 +1,12 @@
 {
   "name": "nativescript-pulltorefresh",
-  "version": "0.1.2",
+  "version": "1.0.0",
   "description": "A NativeScript plugin to provide the Pull to Refresh control on any view.",
   "main": "pulltorefresh.js",
   "nativescript": {
     "platforms": {
-      "android": "1.6.0"
+      "android": "1.6.0", 
+      "ios": "1.6.0"
     }
   },
   "repository": {
@@ -19,7 +20,9 @@
     "Pull Refresh",
     "SwipeRefreshLayout",
     "Material Design",
+    "UIRefreshControl",
     "android",
+    "ios",
     "bradmartin",
     "Thorum"
   ],
@@ -31,7 +34,7 @@
     }, 
     {
       "name": "Peter Staev",
-      "email": "peter.staev@gmail.com",
+      "email": "peter@tangrasoft.com",
       "url": "https://github.com/PeterStaev"
     }
   ],

pulltorefresh.android.js

@@ -51,6 +51,7 @@ var PullToRefresh = (function (_super) {
             onRefresh: function (v) {
                 var owner = that.get();
                 if (owner) {
+                    owner.refreshing = true;
                     owner._emit(common.PullToRefresh.refreshEvent);
                 }
             }

pulltorefresh.android.ts

@@ -35,11 +35,6 @@ export class PullToRefresh extends common.PullToRefresh {
     get _nativeView(): android.support.v4.widget.SwipeRefreshLayout {
         return this._android;
     }
-    
-    //Visibility methods
-    public setRefreshing(newValue: boolean) {
-        this._android.setRefreshing(newValue);
-    }
 
     public _createUI() { 
 
@@ -60,6 +55,7 @@ export class PullToRefresh extends common.PullToRefresh {
             onRefresh: function (v) {
                 var owner = that.get();
                 if (owner) {
+                    owner.refreshing = true;
                     owner._emit(common.PullToRefresh.refreshEvent);
                 }
             }

pulltorefresh.d.ts

@@ -38,11 +38,6 @@ declare module "nativescript-pulltorefresh" {
         */
         refreshing: boolean;
 
-        /*
-        //* Notify the widget that refresh state has changed.
-        //*/
-        //setRefreshing: boolean;
-
         /**
          * Raised when a refresh event occurs.
          */