Skip to content

Commit 2a21849

Browse files
authored
change: make build context the directory with the given dockerfile (aws#86)
1 parent 8f7200b commit 2a21849

File tree

10 files changed

+17
-49
lines changed

10 files changed

+17
-49
lines changed

README.rst

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,17 @@ Example commands for building images:
6262

6363
# All build instructions assume you're starting from this repository's root directory.
6464

65-
# MXNet 1.4.1, Python 3, CPU
66-
$ cp dist/sagemaker_mxnet_serving_container-*.tar.gz docker/1.4.1/py3/sagemaker_mxnet_serving_container.tar.gz
67-
$ cd docker/1.4.1/py3
68-
$ docker build -t preprod-mxnet-serving:1.4.1-cpu-py3 -f Dockerfile.cpu .
69-
70-
# MXNet 1.4.1, Python 2, GPU
71-
$ cp dist/sagemaker_mxnet_serving_container-*.tar.gz dist/sagemaker_mxnet_serving_container.tar.gz
72-
$ docker build -t preprod-mxnet-serving:1.4.1-gpu-py2 -f docker/1.4.1/py2/Dockerfile.gpu .
65+
# MXNet 1.6.0, Python 3, CPU
66+
$ cp dist/sagemaker_mxnet_serving_container-*.tar.gz docker/1.6.0/py3/sagemaker_mxnet_serving_container.tar.gz
67+
$ cp -r docker/artifacts/* docker/1.6.0/py3
68+
$ cd docker/1.6.0/py3
69+
$ docker build -t preprod-mxnet-serving:1.6.0-cpu-py3 -f Dockerfile.cpu .
70+
71+
# MXNet 1.6.0, Python 2, GPU
72+
$ cp dist/sagemaker_mxnet_serving_container-*.tar.gz docker/1.6.0/py2/sagemaker_mxnet_serving_container.tar.gz
73+
$ cp -r docker/artifacts/* docker/1.6.0/py2
74+
$ cd docker/1.6.0/py2
75+
$ docker build -t preprod-mxnet-serving:1.6.0-gpu-py2 -f docker/1.6.0/py2/Dockerfile.gpu .
7376

7477
Don't forget the period at the end of the command!
7578

@@ -165,9 +168,9 @@ To run local integration tests:
165168

166169
# Example
167170
tox test/integration/local -- --docker-base-name preprod-mxnet-serving \
168-
--tag 1.4.0-cpu-py3 \
171+
--tag 1.6.0-cpu-py3 \
169172
--py-version 3 \
170-
--framework-version 1.4.0 \
173+
--framework-version 1.6.0 \
171174
--processor cpu
172175

173176
SageMaker Integration Tests
@@ -202,7 +205,7 @@ To run SageMaker integration tests:
202205
tox test/integration/sagemaker -- --aws-id 12345678910 \
203206
--docker-base-name preprod-mxnet-serving \
204207
--instance-type ml.m4.xlarge \
205-
--tag 1.4.0-cpu-py3
208+
--tag 1.6.0-cpu-py3
206209

207210
If you want to run a SageMaker end to end test for your Elastic Inference container, you will need to provide an ``accelerator_type`` as an additional pytest argument.
208211

buildspec.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ phases:
3434
- cp dist/sagemaker_mxnet_serving_container.tar.gz docker/$FRAMEWORK_FULL_VERSION/py2/sagemaker_mxnet_serving_container.tar.gz
3535
- cp dist/sagemaker_mxnet_serving_container.tar.gz docker/$EI_FRAMEWORK_VERSION/py3/sagemaker_mxnet_serving_container.tar.gz
3636
- cp dist/sagemaker_mxnet_serving_container.tar.gz docker/$EI_FRAMEWORK_VERSION/py2/sagemaker_mxnet_serving_container.tar.gz
37-
- cp src/sagemaker_mxnet_serving_container/deep_learning_container.py docker/$FRAMEWORK_FULL_VERSION/py3/deep_learning_container.py
38-
- cp src/sagemaker_mxnet_serving_container/deep_learning_container.py docker/$FRAMEWORK_FULL_VERSION/py2/deep_learning_container.py
37+
- cp -r docker/artifacts/* docker/$FRAMEWORK_FULL_VERSION/py3
38+
- cp -r docker/artifacts/* docker/$FRAMEWORK_FULL_VERSION/py2
3939

4040
- CPU_PY2_TAG=$FRAMEWORK_FULL_VERSION-cpu-py2
4141
- CPU_PY3_TAG=$FRAMEWORK_FULL_VERSION-cpu-py3

docker/1.6.0/py3/config.properties

Lines changed: 0 additions & 5 deletions
This file was deleted.

docker/1.6.0/py3/mms-entrypoint.py

Lines changed: 0 additions & 29 deletions
This file was deleted.

docker/__init__.py

Whitespace-only changes.

docker/artifacts/__init__.py

Whitespace-only changes.

test/unit/test_deep_learning_container.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,10 @@
1414

1515
import unittest
1616

17+
from docker.artifacts import deep_learning_container as deep_learning_container_to_test
1718
import pytest
1819
import requests
1920

20-
from sagemaker_mxnet_serving_container import deep_learning_container as deep_learning_container_to_test
21-
2221

2322
@pytest.fixture(name='fixture_valid_instance_id')
2423
def fixture_valid_instance_id(requests_mock):

0 commit comments

Comments
 (0)