Skip to content

Commit bc2e08c

Browse files
authored
style: Fix and enforce formatting (#21)
This commit introduces both pycodestyle and isort tooling to the CI check pipeline. These tools ensure a consistent code style and import order across the codebase.
1 parent 583ffcc commit bc2e08c

File tree

4 files changed

+19
-12
lines changed

4 files changed

+19
-12
lines changed

Makefile

+3
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ test: install
3030
lint: #! Run type analysis and linting checks
3131
lint: install
3232
@poetry run mypy ldotel
33+
@poetry run isort --check --atomic ldotel
34+
@poetry run pycodestyle ldotel
35+
3336

3437
#
3538
# Documentation generation

ldotel/testing/test_tracing.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import pytest
2-
3-
from ldotel.tracing import Hook, HookOptions
4-
5-
from ldclient import Config, LDClient, Context
2+
from ldclient import Config, Context, LDClient
63
from ldclient.integrations.test_data import TestData
7-
8-
from opentelemetry.sdk.trace.export.in_memory_span_exporter import InMemorySpanExporter, SpanExporter
9-
from opentelemetry.sdk.trace.export import SimpleSpanProcessor
104
from opentelemetry.sdk.trace import TracerProvider
11-
from opentelemetry.trace import set_tracer_provider, get_tracer_provider, Tracer
5+
from opentelemetry.sdk.trace.export import SimpleSpanProcessor
6+
from opentelemetry.sdk.trace.export.in_memory_span_exporter import (
7+
InMemorySpanExporter, SpanExporter)
8+
from opentelemetry.trace import (Tracer, get_tracer_provider,
9+
set_tracer_provider)
10+
11+
from ldotel.tracing import Hook, HookOptions
1212

1313

1414
@pytest.fixture

ldotel/tracing.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
from ldclient.evaluation import EvaluationDetail
2-
from ldclient.hook import Hook as LDHook, EvaluationSeriesContext, Metadata
1+
from dataclasses import dataclass
32

3+
from ldclient.evaluation import EvaluationDetail
4+
from ldclient.hook import EvaluationSeriesContext
5+
from ldclient.hook import Hook as LDHook
6+
from ldclient.hook import Metadata
47
from opentelemetry import trace
5-
from opentelemetry.trace import Span, set_span_in_context, get_current_span
68
from opentelemetry.context import attach, detach
7-
from dataclasses import dataclass
9+
from opentelemetry.trace import Span, get_current_span, set_span_in_context
810

911

1012
@dataclass

pyproject.toml

+2
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ pytest = ">=2.8"
3636
pytest-cov = ">=2.4.0"
3737
pytest-mypy = "==0.10.3"
3838
mypy = "==1.13.0"
39+
pycodestyle = "^2.12.1"
40+
isort = "^5.13.2"
3941

4042

4143
[tool.poetry.group.docs]

0 commit comments

Comments
 (0)