Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

security issue in dependencies #1604

Closed
marcelschobert opened this issue Oct 14, 2021 · 5 comments
Closed

security issue in dependencies #1604

marcelschobert opened this issue Oct 14, 2021 · 5 comments
Labels
chore Changes to groom the project enhancement good-first-issue For new contributors

Comments

@marcelschobert
Copy link
Contributor

Hi
I have added the newest angular-datatables version (12.0.0) to my project and since 1 week or so there is an known issue with ansi-regex which is included in @angular/cli. That would not be an problem because it normaly is only used in the devDependencies. But angular-datatables has the @angular/cli package in its dependencies and because of that even "npm audit --production" returns an issue.

Is the @angular/cli package really needed in the dependencies or can it be moved to the devDependencies?

@shanmukhateja
Copy link
Collaborator

Hi,

I think it would be safe to move @angular/cli to devDependencies.

PR is always appreciated.

@marcelschobert
Copy link
Contributor Author

Hi @shanmukhateja ,
do you know when the next release will be? It would be nice to have the fixed package.json in my project.

@shanmukhateja
Copy link
Collaborator

Hi @marcelschobert new version v12.0.1 is released to NPM. Please let me know if the issue is fixed.

@shanmukhateja shanmukhateja reopened this Oct 20, 2021
@shanmukhateja
Copy link
Collaborator

I'm closing this issue. Feel free to re-open this if it didn't work @marcelschobert

@marcelschobert
Copy link
Contributor Author

Sorry, I forgot to answer you.
It is working great, thanks for the fast release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Changes to groom the project enhancement good-first-issue For new contributors
Projects
None yet
Development

No branches or pull requests

2 participants