Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

Add unit tests for all Angular components in demo project #1513

Closed
shanmukhateja opened this issue Jan 31, 2021 · 8 comments · Fixed by #1579
Closed

Add unit tests for all Angular components in demo project #1513

shanmukhateja opened this issue Jan 31, 2021 · 8 comments · Fixed by #1579
Labels
chore Changes to groom the project feature request Use to ask for feature request good-first-issue For new contributors pinned Issues to be ignored by Stalebot

Comments

@shanmukhateja
Copy link
Collaborator

Note: We offer assistance for Angular >=8 projects only. Do not open an issue if this is regarding AngularJS issue.

Is your feature request related to a problem? Please describe.

We need to add unit tests for demo project which serves as documentation for the library.

Describe the solution you'd like

Unit tests via spec.ts files for each Angular component inside demo/src/app/

Describe alternatives you've considered

N/A

Additional context
Add any other context or screenshots about the feature request here.

@shanmukhateja shanmukhateja added feature request Use to ask for feature request chore Changes to groom the project good-first-issue For new contributors labels Jan 31, 2021
@stale
Copy link

stale bot commented Apr 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to close issues for inactivity (by bot) label Apr 6, 2021
@shanmukhateja shanmukhateja added pinned Issues to be ignored by Stalebot and removed stale Used to close issues for inactivity (by bot) labels Apr 11, 2021
@sumitgsh
Copy link

@shanmukhateja is it still open..

@shanmukhateja
Copy link
Collaborator Author

@sumitgsh yes this issue is still open.

@sumitgsh
Copy link

@shanmukhateja can u please guide me through like how to write test cases specific to the project , as this is my first time writing test cases in angular

@shanmukhateja
Copy link
Collaborator Author

@sumitgsh I am also not an expert in unit tests. I managed to write some for the demo project as seen in linked PR but it needs work.

Clone the add-unit-tests branch on my fork of this project and run cd demo && ng test. You should see a failing test for "Server side The Angular Way" component. Try to find a way to make it pass or rewrite the spec so its applicable. :)

@sumitgsh
Copy link

Clone the add-unit-tests branch on my fork of this project and run cd demo && ng test. You should see a failing test for "Server side The Angular Way" component. Try to find a way to make it pass or rewrite the spec so its applicable. :)

While I tried running the ng-test under the demo folder ,it not showing any error related to "Server side The Angular Way " component..

I am thinking of writing a spec for that component is it okay with that?

@shanmukhateja
Copy link
Collaborator Author

Not at all. Feel free to work on it.

@shanmukhateja
Copy link
Collaborator Author

@sumitgsh hey were you able to make any progress?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Changes to groom the project feature request Use to ask for feature request good-first-issue For new contributors pinned Issues to be ignored by Stalebot
Projects
None yet
2 participants