Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

Commit 9f33794

Browse files
committed
Correct loading message for multiple dt #355
1 parent 3c880cb commit 9f33794

4 files changed

+12
-20
lines changed

dist/angular-datatables.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -675,10 +675,8 @@ angular.module('datatables.renderer', ['datatables.instances', 'datatables.facto
675675

676676
/* @ngInject */
677677
function dtRendererService(DTLoadingTemplate) {
678-
var $loading = angular.element(DTLoadingTemplate.html);
679678
var plugins = [];
680679
var rendererService = {
681-
getLoadingElem: getLoadingElem,
682680
showLoading: showLoading,
683681
hideLoading: hideLoading,
684682
renderDataTable: renderDataTable,
@@ -689,19 +687,16 @@ function dtRendererService(DTLoadingTemplate) {
689687
};
690688
return rendererService;
691689

692-
function getLoadingElem() {
693-
return $loading;
694-
}
695-
696690
function showLoading($elem) {
691+
var $loading = angular.element(DTLoadingTemplate.html);
697692
$elem.after($loading);
698693
$elem.hide();
699694
$loading.show();
700695
}
701696

702697
function hideLoading($elem) {
703698
$elem.show();
704-
$loading.hide();
699+
$elem.next().remove();
705700
}
706701

707702
function renderDataTable($elem, options) {
@@ -940,6 +935,7 @@ function dtPromiseRenderer($q, $timeout, $log, DTRenderer, DTRendererService, DT
940935
function reloadData(callback, resetPaging) {
941936
var previousPage = _oTable && _oTable.page() ? _oTable.page() : 0;
942937
if (angular.isFunction(renderer.options.fnPromise)) {
938+
DTRendererService.showLoading(_$elem);
943939
_resolve(renderer.options.fnPromise, _redrawRows).then(function(result) {
944940
if (angular.isFunction(callback)) {
945941
callback(result.DataTable.data());
@@ -955,6 +951,7 @@ function dtPromiseRenderer($q, $timeout, $log, DTRenderer, DTRendererService, DT
955951

956952
function changeData(fnPromise) {
957953
renderer.options.fnPromise = fnPromise;
954+
DTRendererService.showLoading(_$elem);
958955
_resolve(renderer.options.fnPromise, _redrawRows);
959956
}
960957

0 commit comments

Comments
 (0)