DTInstance.getList() possible memory leak #284

Author: l-lin

dist/angular-datatables.js

@@ -408,7 +408,8 @@ angular.module('datatables.instances', ['datatables.util'])
     .factory('DTInstanceFactory', dtInstanceFactory);
 
 /* @ngInject */
-function dtInstances($q, failzQ) {
+function dtInstances($q, failzQ, $timeout) {
+    var TIME_BEFORE_CLEANING = 1000;
     var _instances = {};
     var _lastInstance = {};
     // Promise for fetching the last DT instance
@@ -428,7 +429,9 @@ function dtInstances($q, failzQ) {
         dtInstance.DataTable = result.DataTable;
         dtInstance.dataTable = result.dataTable;
 
+        //_instances[dtInstance.id] = dtInstance;
         _instances[dtInstance.id] = dtInstance;
+        _cleanInstances();
         _lastInstance = dtInstance;
         if (_deferLastDTInstances) {
             _deferLastDTInstances.resolve(_lastInstance);
@@ -474,8 +477,22 @@ function dtInstances($q, failzQ) {
         });
         return defer.promise;
     }
+
+    function _cleanInstances() {
+        $timeout(function() {
+            var newInstances = {};
+            for (var attr in _instances) {
+                if (_instances.hasOwnProperty(attr)) {
+                    if ($.fn.DataTable.isDataTable(_instances[attr].id)) {
+                        newInstances[attr] = _instances[attr];
+                    }
+                }
+            }
+            _instances = newInstances;
+        }, TIME_BEFORE_CLEANING);
+    }
 }
-dtInstances.$inject = ['$q', 'failzQ'];
+dtInstances.$inject = ['$q', 'failzQ', '$timeout'];
 
 function dtInstanceFactory() {
     var DTInstance = {