Skip to content

Passing in sql instance #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marbemac opened this issue Oct 23, 2023 · 2 comments · Fixed by #7
Closed

Passing in sql instance #6

marbemac opened this issue Oct 23, 2023 · 2 comments · Fixed by #7
Labels
breaking changes enhancement New feature or request

Comments

@marbemac
Copy link

Any chance this dialect could allow for optionally passing in a sql instance, rather than having the dialect always create it?

The use case here is for when other libraries also need the sql instance (in this case, Lucia Auth https://lucia-auth.com/guidebook/kysely/#postgresql).
@igalklebanov igalklebanov mentioned this issue Oct 26, 2023
Merged
@igalklebanov
Copy link
Member

Hey 👋

Good idea!

Released in v2.

@igalklebanov igalklebanov added enhancement New feature or request breaking changes labels Oct 26, 2023
@marbemac
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking changes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: accept postgres instance. kysely-org/kysely-postgres-js
2 participants
@marbemac @igalklebanov