Skip to content

Commit b855bca

Browse files
committed
Removed default params from resource actions. Added trailing slash to Repository.delete resource URL
1 parent 6e11a97 commit b855bca

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

app/scripts/services/registry-services.js

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,24 +12,22 @@ angular.module('registry-services', ['ngResource'])
1212
return $resource('/v1/search?q=:searchTerm', {}, {
1313
'query': {
1414
method:'GET',
15-
params:{searchTerm:''},
1615
isArray: true,
1716
transformResponse: function(data, headers){
1817
return angular.fromJson(data).results;
1918
}
2019
},
2120
'delete': {
22-
url: '/v1/repositories/:repoUser/:repoName',
21+
url: '/v1/repositories/:repoUser/:repoName/',
2322
method: 'DELETE',
24-
params: {repoUser:'', repoName: ''},
2523
},
2624
});
2725
}])
2826
.factory('Tag', ['$resource', '$log', function($resource, $log){
27+
// TODO: rename :repo to repoUser/repoString for convenience.
2928
return $resource('/v1/repositories/:repo/tags', {}, {
3029
'query': {
3130
method:'GET',
32-
params:{repo:''},
3331
isArray: true,
3432
transformResponse: function(data, headers){
3533
var res = [];
@@ -43,12 +41,10 @@ angular.module('registry-services', ['ngResource'])
4341
'delete': {
4442
url: '/v1/repositories/:repoUser/:repoName/tags/:tagName',
4543
method: 'DELETE',
46-
params: {repoUser:'', repoName: '', tagName: ''},
4744
},
4845
'exists': {
4946
url: '/v1/repositories/:repoUser/:repoName/tags/:tagName',
5047
method: 'GET',
51-
params: {repoUser:'', repoName: '', tagName: ''},
5248
transformResponse: function(data, headers){
5349
// data will be the image ID if successful or an error object.
5450
data = angular.isString(angular.fromJson(data));
@@ -59,17 +55,16 @@ angular.module('registry-services', ['ngResource'])
5955
'save': {
6056
method:'PUT',
6157
url: '/v1/repositories/:repoUser/:repoName/tags/:tagName',
62-
params:{repoUser:'', repoName: '', tagName: ''},
6358
},
6459
});
6560
}])
6661
.factory('Image', ['$resource', '$log', function($resource, $log){
6762
return $resource('/v1/images/:imageId/json', {}, {
68-
query: { method:'GET', params:{imageId:''}, isArray: false},
63+
'query': { method:'GET', isArray: false},
6964
});
7065
}])
7166
.factory('Ancestry', ['$resource', '$log', function($resource, $log){
7267
return $resource('/v1/images/:imageId/ancestry', {}, {
73-
query: { method:'GET', params:{imageId:''}, isArray: true},
68+
'query': { method:'GET', isArray: true},
7469
});
7570
}]);

0 commit comments

Comments
 (0)