Skip to content

Commit 744c5d5

Browse files
authored
[doc] fix bandwidthPerMigration documentation (#2681)
Follow-up on kubevirt/kubevirt#8208 for bandwidthPerMigration. Signed-off-by: Simone Tiraboschi <[email protected]>
1 parent f621412 commit 744c5d5

File tree

10 files changed

+14
-10
lines changed

10 files changed

+14
-10
lines changed

api/v1beta1/hyperconverged_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ type LiveMigrationConfigurations struct {
306306
// +default=2
307307
ParallelOutboundMigrationsPerNode *uint32 `json:"parallelOutboundMigrationsPerNode,omitempty"`
308308

309-
// Bandwidth limit of each migration, in MiB/s.
309+
// Bandwidth limit of each migration, the value is quantity of bytes per second (e.g. 2048Mi = 2048MiB/sec)
310310
// +optional
311311
// +kubebuilder:validation:Pattern=^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
312312
BandwidthPerMigration *string `json:"bandwidthPerMigration,omitempty"`

api/v1beta1/zz_generated.openapi.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/hco.kubevirt.io_hyperconvergeds.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2235,7 +2235,8 @@ spec:
22352235
triggers. Defaults to false
22362236
type: boolean
22372237
bandwidthPerMigration:
2238-
description: Bandwidth limit of each migration, in MiB/s.
2238+
description: Bandwidth limit of each migration, the value is quantity
2239+
of bytes per second (e.g. 2048Mi = 2048MiB/sec)
22392240
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
22402241
type: string
22412242
completionTimeoutPerGiB:

deploy/crds/hco00.crd.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2235,7 +2235,8 @@ spec:
22352235
triggers. Defaults to false
22362236
type: boolean
22372237
bandwidthPerMigration:
2238-
description: Bandwidth limit of each migration, in MiB/s.
2238+
description: Bandwidth limit of each migration, the value is quantity
2239+
of bytes per second (e.g. 2048Mi = 2048MiB/sec)
22392240
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
22402241
type: string
22412242
completionTimeoutPerGiB:

deploy/index-image/community-kubevirt-hyperconverged/1.11.0/manifests/hco00.crd.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2235,7 +2235,8 @@ spec:
22352235
triggers. Defaults to false
22362236
type: boolean
22372237
bandwidthPerMigration:
2238-
description: Bandwidth limit of each migration, in MiB/s.
2238+
description: Bandwidth limit of each migration, the value is quantity
2239+
of bytes per second (e.g. 2048Mi = 2048MiB/sec)
22392240
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
22402241
type: string
22412242
completionTimeoutPerGiB:

deploy/olm-catalog/community-kubevirt-hyperconverged/1.11.0/manifests/hco00.crd.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2235,7 +2235,8 @@ spec:
22352235
triggers. Defaults to false
22362236
type: boolean
22372237
bandwidthPerMigration:
2238-
description: Bandwidth limit of each migration, in MiB/s.
2238+
description: Bandwidth limit of each migration, the value is quantity
2239+
of bytes per second (e.g. 2048Mi = 2048MiB/sec)
22392240
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
22402241
type: string
22412242
completionTimeoutPerGiB:

docs/api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ LiveMigrationConfigurations - Live migration limits and timeouts are applied so
239239
| ----- | ----------- | ------ | -------- |-------- |
240240
| parallelMigrationsPerCluster | Number of migrations running in parallel in the cluster. | *uint32 | 5 | false |
241241
| parallelOutboundMigrationsPerNode | Maximum number of outbound migrations per node. | *uint32 | 2 | false |
242-
| bandwidthPerMigration | Bandwidth limit of each migration, in MiB/s. | *string | | false |
242+
| bandwidthPerMigration | Bandwidth limit of each migration, the value is quantity of bytes per second (e.g. 2048Mi = 2048MiB/sec) | *string | | false |
243243
| completionTimeoutPerGiB | The migration will be canceled if it has not completed in this time, in seconds per GiB of memory. For example, a virtual machine instance with 6GiB memory will timeout if it has not completed migration in 4800 seconds. If the Migration Method is BlockMigration, the size of the migrating disks is included in the calculation. | *int64 | 800 | false |
244244
| progressTimeout | The migration will be canceled if memory copy fails to make progress in this time, in seconds. | *int64 | 150 | false |
245245
| network | The migrations will be performed over a dedicated multus network to minimize disruption to tenant workloads due to network saturation when VM live migrations are triggered. | *string | | false |

docs/cluster-configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ Set the live migration configurations by modifying the fields in the `liveMigrat
245245

246246
### bandwidthPerMigration
247247

248-
Bandwidth limit of each migration, in MiB/s. The format is a number and with the `Mi` suffix, e.g. `2048Mi`.
248+
Bandwidth limit of each migrationi, the value is in quantity of bytes per second. The format is a number with an optional quantity suffix, e.g. `2048Mi` means 2048MiB/sec.
249249

250250
**default**: unset
251251

tests/vendor/github.com/kubevirt/hyperconverged-cluster-operator/api/v1beta1/hyperconverged_types.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/vendor/github.com/kubevirt/hyperconverged-cluster-operator/api/v1beta1/zz_generated.openapi.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)