node-problem-detector --version should not require monitors specify #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Lion-Wei opened this issue Apr 17, 2019 · 0 comments · Fixed by #270

Lion-Wei commented Apr 17, 2019

Currently node-problem-detector --version command request monitor specified

./node-problem-detector --version
panic: Either --system-log-monitors or --custom-plugin-monitors is required

goroutine 1 [running]:
k8s.io/node-problem-detector/cmd/options.(*NodeProblemDetectorOptions).ValidOrDie(0xc000175900)
	/usr1/go/src/k8s.io/node-problem-detector/cmd/options/options.go:99 +0x13d
main.main()
	/usr1/go/src/k8s.io/node-problem-detector/cmd/node_problem_detector.go:65 +0x82

That's not necessary, and if we use node-problem-detector --version --system-log-monitors=./, that would be little weird.

The text was updated successfully, but these errors were encountered:

Lion-Wei mentioned this issue

fix node-problem-detector --version to not require monitors specify #270

Merged

k8s-ci-robot closed this as completed in #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment