Merge pull request #510 from jeremyje/nopanic

k8s-ci-robot · web-flow · commit f564d9092a6f · 2021-01-08T14:43:05.000-08:00
Use Fatal instead of panic for go tests.
diff --git a/test/e2e/metriconly/e2e_npd_test.go b/test/e2e/metriconly/e2e_npd_test.go
@@ -73,7 +73,7 @@ func TestNPD(t *testing.T) {
 	var err error
 	computeService, err = gce.GetComputeClient()
 	if err != nil {
-		panic(fmt.Sprintf("Unable to create gcloud compute service using defaults. Make sure you are authenticated. %v", err))
+		t.Fatalf("Unable to create gcloud compute service using defaults. Make sure you are authenticated. %v", err)
 	}
 
 	if *artifactsDir != "" {

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ func TestNPD(t *testing.T) {`
`73`	`73`	`var err error`
`74`	`74`	`computeService, err = gce.GetComputeClient()`
`75`	`75`	`if err != nil {`
`76`		`- panic(fmt.Sprintf("Unable to create gcloud compute service using defaults. Make sure you are authenticated. %v", err))`
	`76`	`+ t.Fatalf("Unable to create gcloud compute service using defaults. Make sure you are authenticated. %v", err)`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`if *artifactsDir != "" {`