Skip to content

Commit e14c3e4

Browse files
committed
Add make release
Adds a `make release` command for releasing new NPD version. It stops pushing the tar files to gs://kubernetes-release, because no one has write permission to the GCS bucket any more. We haven't pushed NPD tar files to that GCS bucket after v0.8.10. k/k has been using NPD v0.8.13+ since 1.29. NPD release should just include the tar files in the release note.
1 parent 58211f1 commit e14c3e4

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

Makefile

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
.PHONY: all \
1818
vet fmt version test e2e-test \
1919
build-binaries build-container build-tar build \
20-
docker-builder build-in-docker push-container push-tar push clean depup
20+
docker-builder build-in-docker \
21+
push-container push-tar push release clean depup
2122

2223
all: build
2324

@@ -268,8 +269,12 @@ push-tar: build-tar
268269
gsutil cp $(TARBALL) $(UPLOAD_PATH)/node-problem-detector/
269270
gsutil cp node-problem-detector-$(VERSION)-*.tar.gz* $(UPLOAD_PATH)/node-problem-detector/
270271

272+
# `make push` is used by presubmit and CI jobs.
271273
push: push-container push-tar
272274

275+
# `make release` is used when releasing a new NPD version.
276+
release: push-container build-tar
277+
273278
coverage.out:
274279
rm -f coverage.out
275280
go test -coverprofile=coverage.out -timeout=1m -v -short ./...

docs/release_process.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ section to perform steps in this section.**
5858
sudo apt-get install libsystemd-dev gcc-aarch64-linux-gnu
5959
6060
cd node-problem-detector
61-
make push
61+
make release
6262
6363
# Get SHA256 of the tar files. For example
6464
sha256sum node-problem-detector-v0.8.17-linux_amd64.tar.gz

0 commit comments

Comments
 (0)