Skip to content

Commit 4e0b915

Browse files
committed
CI: build container and push tar, PR: push tar
We only need the tar to run CI tests, but we should also test building the container. We release the container and binaries independently of this, this script is for e2e tests.
1 parent 34e60f8 commit 4e0b915

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

test/build.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ function build-pr() {
128128
export REGISTRY="${NPD_STAGING_REGISTRY}/pr/${PR}"
129129
export VERSION=$(get-version)
130130
export TAG="${VERSION}"
131-
make push
131+
make push-tar
132132
write-env-file ${PR_ENV_FILENAME}
133133
}
134134

@@ -138,7 +138,10 @@ function build-ci() {
138138
export REGISTRY="${NPD_STAGING_REGISTRY}/ci"
139139
export VERSION="$(get-version)-$(date +%Y%m%d.%H%M)"
140140
export TAG="${VERSION}"
141-
make push
141+
# e2e tests consume the tarball, not the container
142+
# this is simpler to manage in the infra, and we still ensure the container
143+
# build works locally
144+
make push-tar build-container
142145

143146
# Create the env file with and without custom flags at the same time.
144147
build-npd-custom-flags

0 commit comments

Comments
 (0)