Skip to content

Commit 19c6f4d

Browse files
committed
updates
Signed-off-by: Sertac Ozercan <[email protected]>
1 parent 0dde605 commit 19c6f4d

File tree

3 files changed

+37
-28
lines changed

3 files changed

+37
-28
lines changed

Diff for: .github/dependabot.yml

+30-16
Original file line numberDiff line numberDiff line change
@@ -3,39 +3,53 @@ updates:
33
- package-ecosystem: github-actions
44
directory: /
55
schedule:
6-
interval: daily
6+
interval: weekly
7+
groups:
8+
actions-all:
9+
patterns:
10+
- "*"
711

812
- package-ecosystem: docker
913
directory: /
1014
schedule:
11-
interval: daily
15+
interval: weekly
1216

1317
- package-ecosystem: gomod
1418
directory: /
1519
schedule:
16-
interval: daily
20+
interval: weekly
21+
ignore:
22+
- dependency-name: "*"
23+
update-types:
24+
- "version-update:semver-major"
25+
- "version-update:semver-minor"
26+
groups:
27+
k8s:
28+
patterns:
29+
- "k8s.io/*"
30+
- "sigs.k8s.io/*"
1731

1832
- package-ecosystem: docker
1933
directory: /pkg/util/nethealth
2034
schedule:
21-
interval: daily
35+
interval: weekly
2236

2337
- package-ecosystem: gomod
2438
directory: /test
2539
schedule:
26-
interval: daily
40+
interval: weekly
41+
ignore:
42+
- dependency-name: "*"
43+
update-types:
44+
- "version-update:semver-major"
45+
- "version-update:semver-minor"
46+
groups:
47+
k8s:
48+
patterns:
49+
- "k8s.io/*"
50+
- "sigs.k8s.io/*"
2751

2852
- package-ecosystem: docker
2953
directory: /test/kernel_log_generator
3054
schedule:
31-
interval: daily
32-
33-
- package-ecosystem: docker
34-
directory: /vendor/github.com/hpcloud/tail
35-
schedule:
36-
interval: daily
37-
38-
- package-ecosystem: pip
39-
directory: /vendor/go.opentelemetry.io/otel
40-
schedule:
41-
interval: daily
55+
interval: weekly

Diff for: Dockerfile

+4-6
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,15 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14-
ARG BASEIMAGE
1514

1615
# "builder-base" can be overriden using dockerb buildx's --build-context flag,
17-
# by users who want to use a different images for the builder. E.g. if you need to use an older OS
16+
# by users who want to use a different images for the builder. E.g. if you need to use an older OS
1817
# to avoid dependencies on very recent glibc versions.
1918
# E.g. of the param: --build-context builder-base=docker-image://golang:<something>@sha256:<something>
2019
# Must override builder-base, not builder, since the latter is referred to later in the file and so must not be
21-
# directly replaced. See here, and note that "stage" parameter mentioned there has been renamed to
20+
# directly replaced. See here, and note that "stage" parameter mentioned there has been renamed to
2221
# "build-context": https://github.com/docker/buildx/pull/904#issuecomment-1005871838
23-
FROM golang:1.22.3-bookworm@sha256:5c56bd47228dd572d8a82971cf1f946cd8bb1862a8ec6dc9f3d387cc94136976 as builder-base
22+
FROM golang:1.22-bookworm@sha256:5c56bd47228dd572d8a82971cf1f946cd8bb1862a8ec6dc9f3d387cc94136976 as builder-base
2423
FROM builder-base as builder
2524
LABEL maintainer="Andy Xie <[email protected]>"
2625

@@ -36,8 +35,7 @@ COPY . /gopath/src/k8s.io/node-problem-detector/
3635
WORKDIR /gopath/src/k8s.io/node-problem-detector
3736
RUN GOARCH=${TARGETARCH} make bin/node-problem-detector bin/health-checker bin/log-counter
3837

39-
ARG BASEIMAGE
40-
FROM --platform=${TARGETPLATFORM} ${BASEIMAGE}
38+
FROM --platform=${TARGETPLATFORM} registry.k8s.io/build-image/debian-base:bookworm-v1.0.4@sha256:b30608f5a81f8ba99b287322d0bfb77ec506adcce396147aa4a59699d69be3e0 as base
4139

4240
LABEL maintainer="Random Liu <[email protected]>"
4341

Diff for: Makefile

+3-6
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@ else ifeq ($(shell go env GOHOSTOS), windows)
7272
ENABLE_JOURNALD=0
7373
endif
7474

75-
# Set default base image to Debian 12 (Bookworm)
76-
BASEIMAGE:=registry.k8s.io/build-image/debian-base:bookworm-v1.0.3
77-
7875
# Disable cgo by default to make the binary statically linked.
7976
CGO_ENABLED:=0
8077

@@ -238,7 +235,7 @@ build-binaries: $(ALL_BINARIES)
238235

239236
build-container: clean Dockerfile
240237
docker buildx create --platform $(DOCKER_PLATFORMS) --use
241-
docker buildx build --platform $(DOCKER_PLATFORMS) -t $(IMAGE) --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg LOGCOUNTER=$(LOGCOUNTER) .
238+
docker buildx build --platform $(DOCKER_PLATFORMS) -t $(IMAGE) --build-arg LOGCOUNTER=$(LOGCOUNTER) .
242239

243240
$(TARBALL): ./bin/node-problem-detector ./bin/log-counter ./bin/health-checker ./test/bin/problem-maker
244241
tar -zcvf $(TARBALL) bin/ config/ test/e2e-install.sh test/bin/problem-maker
@@ -250,7 +247,7 @@ build-tar: $(TARBALL) $(ALL_TARBALLS)
250247
build: build-container build-tar
251248

252249
docker-builder:
253-
docker build -t npd-builder . --target=builder --build-arg BASEIMAGE=$(BASEIMAGE)
250+
docker build -t npd-builder . --target=builder
254251

255252
build-in-docker: clean docker-builder
256253
docker run \
@@ -263,7 +260,7 @@ ifneq (,$(findstring gcr.io,$(REGISTRY)))
263260
gcloud auth configure-docker
264261
endif
265262
# Build should be cached from build-container
266-
docker buildx build --push --platform $(DOCKER_PLATFORMS) -t $(IMAGE) --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg LOGCOUNTER=$(LOGCOUNTER) .
263+
docker buildx build --push --platform $(DOCKER_PLATFORMS) -t $(IMAGE) --build-arg LOGCOUNTER=$(LOGCOUNTER) .
267264

268265
push-tar: build-tar
269266
gsutil cp $(TARBALL) $(UPLOAD_PATH)/node-problem-detector/

0 commit comments

Comments
 (0)