Skip to content

Commit e4deee8

Browse files
committed
slog: use main logr package instead of logr/slogr
logr v1.4.0 moved the slog support functions in the main package and deprecated slogr.
1 parent 5d1d2d5 commit e4deee8

File tree

3 files changed

+18
-17
lines changed

3 files changed

+18
-17
lines changed

klogr_slog.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
"strconv"
2626
"time"
2727

28-
"github.com/go-logr/logr/slogr"
28+
"github.com/go-logr/logr"
2929

3030
"k8s.io/klog/v2/internal/buffer"
3131
"k8s.io/klog/v2/internal/serialize"
@@ -35,7 +35,7 @@ import (
3535

3636
func (l *klogger) Handle(ctx context.Context, record slog.Record) error {
3737
if logging.logger != nil {
38-
if slogSink, ok := logging.logger.GetSink().(slogr.SlogSink); ok {
38+
if slogSink, ok := logging.logger.GetSink().(logr.SlogSink); ok {
3939
// Let that logger do the work.
4040
return slogSink.Handle(ctx, record)
4141
}
@@ -77,13 +77,13 @@ func slogOutput(file string, line int, now time.Time, err error, s severity.Seve
7777
buffer.PutBuffer(b)
7878
}
7979

80-
func (l *klogger) WithAttrs(attrs []slog.Attr) slogr.SlogSink {
80+
func (l *klogger) WithAttrs(attrs []slog.Attr) logr.SlogSink {
8181
clone := *l
8282
clone.values = serialize.WithValues(l.values, sloghandler.Attrs2KVList(l.groups, attrs))
8383
return &clone
8484
}
8585

86-
func (l *klogger) WithGroup(name string) slogr.SlogSink {
86+
func (l *klogger) WithGroup(name string) logr.SlogSink {
8787
clone := *l
8888
if clone.groups != "" {
8989
clone.groups += "." + name
@@ -93,4 +93,4 @@ func (l *klogger) WithGroup(name string) slogr.SlogSink {
9393
return &clone
9494
}
9595

96-
var _ slogr.SlogSink = &klogger{}
96+
var _ logr.SlogSink = &klogger{}

klogr_slog_test.go

+9-8
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ import (
2727
"os"
2828
"time"
2929

30-
"github.com/go-logr/logr/slogr"
30+
"github.com/go-logr/logr"
31+
3132
"k8s.io/klog/v2"
3233
internal "k8s.io/klog/v2/internal/buffer"
3334
)
@@ -71,7 +72,7 @@ func ExampleBackground_Slog() {
7172
internal.Pid = 123
7273

7374
logrLogger := klog.Background()
74-
slogHandler := slogr.NewSlogHandler(logrLogger)
75+
slogHandler := logr.ToSlogHandler(logrLogger)
7576
slogLogger := slog.New(slogHandler)
7677

7778
// Note that -vmodule does not work when using the slog API because
@@ -107,10 +108,10 @@ func ExampleBackground_Slog() {
107108
)
108109

109110
// Output:
110-
// I1224 12:30:40.000000 123 klogr_slog_test.go:80] "A debug message"
111-
// I1224 12:30:40.000000 123 klogr_slog_test.go:82] "An info message"
112-
// W1224 12:30:40.000000 123 klogr_slog_test.go:83] "A warning"
113-
// E1224 12:30:40.000000 123 klogr_slog_test.go:84] "An error" err="fake error"
114-
// I1224 12:30:40.000000 123 klogr_slog_test.go:87] "Grouping" top.sub={"str":"abc","bool":true,"bottom":{"coordinates":{"X":-1,"Y":-2}}} top.duration="1s" top.pi=3.12 top.e=2.71 top.moreCoordinates={"X":100,"Y":200}
115-
// I1224 12:30:40.000000 123 klogr_slog_test.go:103] "slog values" variables={"a":1,"b":2} duration="1s" coordinates={"X":100,"Y":200}
111+
// I1224 12:30:40.000000 123 klogr_slog_test.go:81] "A debug message"
112+
// I1224 12:30:40.000000 123 klogr_slog_test.go:83] "An info message"
113+
// W1224 12:30:40.000000 123 klogr_slog_test.go:84] "A warning"
114+
// E1224 12:30:40.000000 123 klogr_slog_test.go:85] "An error" err="fake error"
115+
// I1224 12:30:40.000000 123 klogr_slog_test.go:88] "Grouping" top.sub={"str":"abc","bool":true,"bottom":{"coordinates":{"X":-1,"Y":-2}}} top.duration="1s" top.pi=3.12 top.e=2.71 top.moreCoordinates={"X":100,"Y":200}
116+
// I1224 12:30:40.000000 123 klogr_slog_test.go:104] "slog values" variables={"a":1,"b":2} duration="1s" coordinates={"X":100,"Y":200}
116117
}

textlogger/textlogger_slog.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
"context"
2424
"log/slog"
2525

26-
"github.com/go-logr/logr/slogr"
26+
"github.com/go-logr/logr"
2727

2828
"k8s.io/klog/v2/internal/serialize"
2929
"k8s.io/klog/v2/internal/sloghandler"
@@ -33,13 +33,13 @@ func (l *tlogger) Handle(ctx context.Context, record slog.Record) error {
3333
return sloghandler.Handle(ctx, record, l.groups, l.printWithInfos)
3434
}
3535

36-
func (l *tlogger) WithAttrs(attrs []slog.Attr) slogr.SlogSink {
36+
func (l *tlogger) WithAttrs(attrs []slog.Attr) logr.SlogSink {
3737
clone := *l
3838
clone.values = serialize.WithValues(l.values, sloghandler.Attrs2KVList(l.groups, attrs))
3939
return &clone
4040
}
4141

42-
func (l *tlogger) WithGroup(name string) slogr.SlogSink {
42+
func (l *tlogger) WithGroup(name string) logr.SlogSink {
4343
clone := *l
4444
if clone.groups != "" {
4545
clone.groups += "." + name
@@ -49,4 +49,4 @@ func (l *tlogger) WithGroup(name string) slogr.SlogSink {
4949
return &clone
5050
}
5151

52-
var _ slogr.SlogSink = &tlogger{}
52+
var _ logr.SlogSink = &tlogger{}

0 commit comments

Comments
 (0)