Skip to content

Commit 1025055

Browse files
pohlydims
authored andcommitted
github: bump golangci-lint image version
It looks like golangci-lint comes with a fixed version of Go, one which is too old for the code: level=error msg="Running error: gofmt: analysis skipped: errors in package: [/go/src/k8s.io/klog/test/output.go:846:22: Discard not declared by package io /go/src/k8s.io/klog/test/output.go:864:40: Discard not declared by package io /go/src/k8s.io/klog/test/output.go:876:35: Discard not declared by package io]" io.Discard was introduced in Go 1.16, using it should be fine and is reflected in our Go version test matrix (>= 1.17).
1 parent 8eadf2c commit 1025055

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: Lint
3131
run: |
3232
docker run --rm -v `pwd`:/go/src/k8s.io/klog -w /go/src/k8s.io/klog \
33-
golangci/golangci-lint:v1.23.8 golangci-lint run --disable-all -v \
33+
golangci/golangci-lint:v1.50.1 golangci-lint run --disable-all -v \
3434
-E govet -E misspell -E gofmt -E ineffassign -E golint
3535
apidiff:
3636
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)