Skip to content

Commit c260948

Browse files
authored
Merge pull request #4195 from aramase/aramase/d/kep_3331_update_based_on_impl
KEP-3331: rename clientIDs to audiences based on current impl
2 parents fc83428 + cc018e1 commit c260948

File tree

1 file changed

+4
-5
lines changed
  • keps/sig-auth/3331-structured-authentication-configuration

1 file changed

+4
-5
lines changed

Diff for: keps/sig-auth/3331-structured-authentication-configuration/README.md

+4-5
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ kind: AuthenticationConfiguration
205205
jwt:
206206
- issuer:
207207
url: https://example.com
208-
clientIDs:
208+
audiences:
209209
- my-app
210210
claimValidationRules:
211211
- claim: hd
@@ -364,11 +364,11 @@ type JWTAuthenticator struct {
364364
// +optional
365365
CertificateAuthority string `json:"certificateAuthority,omitempty"`
366366

367-
// clientIDs is the set of acceptable audiences the JWT must be issued to.
367+
// audiences is the set of acceptable audiences the JWT must be issued to.
368368
// At least one of the entries must match the "aud" claim in presented JWTs.
369369
// Same value as the --oidc-client-id flag (though this field supports an array).
370370
// Required to be non-empty.
371-
ClientIDs []string `json:"clientIDs,omitempty"`
371+
Audiences []string `json:"audiences,omitempty"`
372372
}
373373
```
374374

@@ -433,6 +433,7 @@ type JWTAuthenticator struct {
433433
// (2) if userName.prefix = "" and userName.claim != "email", prefix will be "<issuer.url>#"
434434
// (3) if userName.expression is set instead, result of expression is used as-is without any implicit prefix
435435
// (1) and (2) ensure backward compatibility with the --oidc-username-claim and --oidc-username-prefix flags
436+
// +required
436437
Username PrefixedClaimOrExpression `json:"username"`
437438
// groups represents an option for the groups attribute.
438439
// Claim must be a string or string array claim.
@@ -733,8 +734,6 @@ providers such as Okta, Azure AD, etc:
733734
#### Deprecation
734735

735736
kube-apiserver `--oidc-*` flags require deprecation warnings on the stable release of the feature.
736-
It is possible to react only to the `--oidc-issuer-url` flag because other flags cannot be enabled separately from this one.
737-
738737

739738
### Upgrade / Downgrade Strategy
740739

0 commit comments

Comments
 (0)