Skip to content

Commit 813f990

Browse files
authored
Merge pull request #4238 from klueska/KEP-4009/Add-CDI-devices-to-device-plugin-API
Update CDI for device plugins KEP for beta graduation
2 parents fd85a2f + 7f43998 commit 813f990

File tree

3 files changed

+24
-3
lines changed

3 files changed

+24
-3
lines changed
+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 4009
22
alpha:
33
approver: "@johnbelamaric"
4+
beta:
5+
approver: "@johnbelamaric"

keps/sig-node/4009-add-cdi-devices-to-device-plugin-api/README.md

+19-1
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,12 @@ However, these cases will be added in the existing integration tests:
151151
These cases will be added in the existing `e2e_node` tests:
152152
- Device Plugin works with CDI devices
153153

154+
Links to tests:
155+
- TBD: Will fill-in by code freeze
156+
157+
Links to k8s-triage for tests:
158+
- TBD: Will fill-in by code freeze
159+
154160
### Graduation Criteria
155161

156162
#### Alpha
@@ -315,11 +321,22 @@ No
315321

316322
### Troubleshooting
317323

324+
###### How does this feature react if the API server and/or etcd is unavailable?
325+
318326
N/A
319327

320328
###### What are other known failure modes?
321329

322-
TBD
330+
The change to Kubernetes to support this feature is very minimal. The CDI
331+
device list passed from the plugin to the kubelet is opaquely forwarded to the
332+
underlying container runtime without affecting the overall logic of the kubelet
333+
in any significant way. As such, the only known failure scenarios result from
334+
plugins themselves doing something incorrectly (not the kubelet). For example,
335+
sending back a list of CDI devices that are not included in any CDI spec
336+
visible to the underlying container runtime. However, such failure scenarios do
337+
not affect the proper functioning of kubernetes itself, and are therefore out
338+
of scope for this KEP. We recommend you check the device plugin and container
339+
runtime logs instead.
323340

324341
###### What steps should be taken if SLOs are not being met to determine the problem?
325342

@@ -328,6 +345,7 @@ N/A
328345
## Implementation History
329346

330347
- 2023-05-15: KEP created
348+
- 2023-09-25: KEP updated to mark transition to beta
331349

332350
## Drawbacks
333351

keps/sig-node/4009-add-cdi-devices-to-device-plugin-api/kep.yaml

+3-2
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ status: implementable
88
creation-date: 2023-05-16
99
reviewers:
1010
- swatisehgal
11+
- kklues
1112
approvers:
1213
- mrunalp
1314

@@ -17,12 +18,12 @@ see-also:
1718
replaces: []
1819

1920
# The target maturity stage in the current dev cycle for this KEP.
20-
stage: alpha
21+
stage: beta
2122

2223
# The most recent milestone for which work toward delivery of this KEP has been
2324
# done. This can be the current (upcoming) milestone, if it is being actively
2425
# worked on.
25-
latest-milestone: "v1.28"
26+
latest-milestone: "v1.29"
2627

2728
# The milestone at which this feature was, or is targeted to be, at each stage.
2829
milestone:

0 commit comments

Comments
 (0)