Skip to content

Commit 63cae27

Browse files
authored
Merge pull request #3914 from gjkim42/2595-promote-to-ga
KEP-2595: Promote to the GA stage
2 parents 51bce99 + c710c9c commit 63cae27

File tree

3 files changed

+22
-7
lines changed

3 files changed

+22
-7
lines changed

keps/prod-readiness/sig-network/2595.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ alpha:
33
approver: "@johnbelamaric"
44
beta:
55
approver: "@johnbelamaric"
6+
stable:
7+
approver: "@johnbelamaric"

keps/sig-network/2595-expanded-dns-config/README.md

+16-3
Original file line numberDiff line numberDiff line change
@@ -152,14 +152,17 @@ Verified that the API server accepts the pod or podTemplate with the expanded
152152
DNS config and the kubelet accepts the resolv.conf or pod with the expanded DNS
153153
config.
154154

155+
- `k8s.io/kubernetes/pkg/kubelet/network/dns/dns.go`: `2023/04/22` - `68.7%`
156+
155157
##### Integration tests
156158

157159
No integration tests are planned.
158160

159161
##### e2e tests
160162

161-
Will add an e2e test to ensure that the pod with the expanded DNS config can be
162-
created and run successfully.
163+
Tests in `test/e2e/network/dns.go`:
164+
165+
- [It] [sig-network] DNS should work with the pod containing more than 6 DNS search paths and longer than 256 search list characters: [results](https://storage.googleapis.com/k8s-triage/index.html?job=ci-kubernetes-kind-e2e-parallel&test=should%20work%20with%20the%20pod%20containing%20more%20than%206%20DNS%20search%20paths%20and%20longer%20than%20256%20search%20list%20characters)
163166

164167
### Graduation Criteria
165168

@@ -221,7 +224,7 @@ the expanded DNS configuration.
221224

222225
Yes, the feature can be disabled by disabling the feature gate.
223226

224-
Before disabling the feature gate, is is recommended to remove objects
227+
Before disabling the feature gate, it is recommended to remove objects
225228
containing podsTemplate with the expanded DNS config as newly created pods will
226229
be rejected by the apiserver.
227230

@@ -356,6 +359,12 @@ The DNS lookup time can be increased, but it will be negligible.
356359

357360
No
358361

362+
- **Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?**
363+
364+
No, this cannot result in resource exhaustion of node resources as setting
365+
longer DNS search list to `/etc/resolv.conf` only affects the process running
366+
inside the container.
367+
359368
### Troubleshooting
360369

361370
- **How does this feature react if the API server and/or etcd is unavailable?**
@@ -384,6 +393,10 @@ merged](https://github.com/kubernetes/kubernetes/pull/100651)
384393
merged](https://github.com/kubernetes/website/pull/28096)
385394
- 2022-01-12: [Docs updated to add requirements for the
386395
feature](https://github.com/kubernetes/website/pull/31305)
396+
- 2022-08-15: [Beta implementation
397+
merged](https://github.com/kubernetes/kubernetes/pull/112824)
398+
- 2022-08-22: [Beta docs
399+
merged](https://github.com/kubernetes/website/pull/37364)
387400

388401
## Drawbacks
389402

keps/sig-network/2595-expanded-dns-config/kep.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ authors:
55
owning-sig: sig-network
66
participating-sigs:
77
- sig-node
8-
status: implementable
8+
status: implemented
99
creation-date: 2021-04-02
1010
reviewers:
1111
- "@thockin"
@@ -21,18 +21,18 @@ see-also:
2121
replaces:
2222

2323
# The target maturity stage in the current dev cycle for this KEP.
24-
stage: beta
24+
stage: stable
2525

2626
# The most recent milestone for which work toward delivery of this KEP has been
2727
# done. This can be the current (upcoming) milestone, if it is being actively
2828
# worked on.
29-
latest-milestone: "v1.26"
29+
latest-milestone: "v1.28"
3030

3131
# The milestone at which this feature was, or is targeted to be, at each stage.
3232
milestone:
3333
alpha: "v1.22"
3434
beta: "v1.26"
35-
stable: "x.y"
35+
stable: "v1.28"
3636

3737
# The following PRR answers are required at alpha release
3838
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)