Skip to content

Commit 46c0656

Browse files
authored
Merge pull request #3971 from nabokihms/3325-self-subject-review-stable
KEP-3325: Promote SelfSubjectReview to Stable
2 parents 07272ad + afeddbb commit 46c0656

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

keps/prod-readiness/sig-auth/3325.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ alpha:
33
approver: "@deads2k"
44
beta:
55
approver: "@deads2k"
6+
stable:
7+
approver: "@deads2k"

keps/sig-auth/3325-self-subject-attributes-review-api/README.md

+5-4
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ The motivation for this KEP is to reduce obscurity and help users with debugging
7171
### Goals
7272

7373
- Add the API endpoint to get user attributes
74-
- Add a corresponding kubectl command - `kubectl auth who-am-i`
74+
- Add a corresponding kubectl command - `kubectl auth whoami`
7575

7676
### Non-Goals
7777

@@ -236,6 +236,7 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
236236
-->
237237

238238
- `k8s.io/kubernetes/test/e2e/auth/selfsubjectreview.go`
239+
- `k8s.io/kubernetes/test/cmd/auth_whoami.sh`
239240

240241
### Graduation Criteria
241242

@@ -254,7 +255,8 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
254255
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1beta1` API (Beta APIs are not enabled by default, [see](https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/3136-beta-apis-off-by-default/README.md)).
255256
- Promote feature gate to Beta and make it enabled by default
256257
- Unit tests coverage improved
257-
- `kubectl alpha auth whoami` command uses `authentication.k8s.io/v1beta1` API, falls back to `authentication.k8s.io/v1alpha1` API
258+
- `kubectl alpha auth whoami` replaced with `kubectl auth whoami`
259+
- `kubectl auth whoami` command uses `authentication.k8s.io/v1beta1` API, falls back to `authentication.k8s.io/v1alpha1` API
258260
- Fix [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#self-subject-review):
259261
- Change API version
260262
- Rewrite conditions to enable the feature
@@ -263,13 +265,12 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
263265

264266
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1` API and enable by default
265267
- Promote feature gate to Stable
266-
- `kubectl alpha auth whoami` replaced with `kubectl auth whoami`
267268
- `kubectl auth whoami` command prefers `authentication.k8s.io/v1` API over `authentication.k8s.io/v1beta1` and `authentication.k8s.io/v1alpha1`
268269
- More integration and e2e tests cases
270+
- Add `test/cmd` test
269271
- Fix [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#self-subject-review):
270272
- Change API version
271273
- Rewrite conditions to enable the feature
272-
- Change kubectl command
273274

274275
NOTE: Should not be a part of [conformance tests](https://git.k8s.io/community/contributors/devel/sig-architecture/conformance-tests.md).
275276
The fact that a user possesses a token does not necessarily imply the power to know to whom that token belongs.

keps/sig-auth/3325-self-subject-attributes-review-api/kep.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ approvers:
1616
- "@liggitt"
1717
creation-date: "2022-05-30"
1818
status: implementable
19-
stage: beta
20-
latest-milestone: "v1.27"
19+
stage: stable
20+
latest-milestone: "v1.28"
2121
milestone:
2222
alpha: "v1.26"
2323
beta: "v1.27"

0 commit comments

Comments
 (0)