Skip to content

Commit 26fb413

Browse files
committed
KEP 3157 (watch-list): update the feature name used by KCM
1 parent 6ef187f commit 26fb413

File tree

1 file changed

+5
-5
lines changed
  • keps/sig-api-machinery/3157-watch-list

1 file changed

+5
-5
lines changed

keps/sig-api-machinery/3157-watch-list/README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -958,12 +958,12 @@ W1002 09:11:40.656641 1 reflector.go:340] The watch-list feature is not su
958958
959959
```
960960

961-
Disable the `WatchList` feature gate for the `kcm` by editing the static pod manifest directly.
961+
Disable the `WatchListClient` feature gate for the `kcm` by editing the static pod manifest directly.
962962
```
963963
docker exec -ti kind-control-plane bash
964964
vim /etc/kubernetes/manifests/kube-controller-manager.yaml
965965
```
966-
and pass `- --feature-gates=WatchList=false` to the `kcm` container.
966+
and pass `- --feature-gates=WatchListClient=false` to the `kcm` container.
967967

968968
Check if `kcm` is running.
969969
```
@@ -1003,12 +1003,12 @@ Check if the `kas` has not recorded the watchlist latency metric.
10031003
kubectl get --raw '/metrics' | grep "apiserver_watch_list_duration_seconds"
10041004
```
10051005

1006-
Enable the `WatchList` feature gate for the `kcm` by editing the static pod manifest directly.
1006+
Enable the `WatchListClient` feature gate for the `kcm` by editing the static pod manifest directly.
10071007
```
10081008
docker exec -ti kind-control-plane bash
10091009
vim /etc/kubernetes/manifests/kube-controller-manager.yaml
10101010
```
1011-
and remove `- --feature-gates=WatchList=false` for the `cm` container.
1011+
and remove `- --feature-gates=WatchListClient=false` for the `cm` container.
10121012

10131013
Check if `kcm` is running.
10141014
```
@@ -1252,7 +1252,7 @@ When etcd is unavailable, requests attempting to retrieve the most recent state
12521252
- kube-controller-manager is unable to start.
12531253
- Detection: How can it be detected via metrics? Examine the prometheus `up` time series or examine the pod status or the number of restarts.
12541254
- Mitigations: What can be done to stop the bleeding, especially for already
1255-
running user workloads? Disable the feature. Pass `WatchList=false` to `feature-gates` command line flag.
1255+
running user workloads? Disable the feature. Pass `WatchListClient=false` to `feature-gates` command line flag.
12561256
- Diagnostics: What are the useful log messages and their required logging
12571257
levels that could help debug the issue? N/A
12581258
- Testing: Are there any tests for failure mode? If not, describe why. Yes, if kube-controller-manager is unable to start then a lot of existing e2e tests will fail.

0 commit comments

Comments
 (0)