Skip to content

Commit 1202981

Browse files
authored
Merge pull request #4158 from xuzhenglun/master
promote ServiceNodePortStaticSubrange to stable
2 parents e331745 + e00b191 commit 1202981

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

keps/prod-readiness/sig-network/3668.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ alpha:
33
approver: "@wojtek-t"
44
beta:
55
approver: "@wojtek-t"
6+
stable:
7+
approver: "@wojtek-t"

keps/sig-network/3668-reserved-service-nodeport-range/README.md

+10-4
Original file line numberDiff line numberDiff line change
@@ -305,8 +305,9 @@ This feature doesn't modify the cluster behavior, only the order on which dynami
305305
306306
#### GA
307307
308-
- No issues reported during two releases.
309-
308+
- No issues reported during one release. This is because the feature is built on the top of
309+
[ServiceIPStaticSubrange](https://kep.k8s.io/3070), which has been GA since v1.26.
310+
Consequently, there is no need for any additional probation period.
310311
311312
### Upgrade / Downgrade Strategy
312313
@@ -369,6 +370,10 @@ There is currently no metric available for the NodePort allocation. so 4 metric
369370
- kube_apiserver_nodeport_allocator_allocation_total
370371
- kube_apiserver_nodeport_allocator_allocation_errors_total
371372
373+
The increase of the errors metrics or the trend of the allocated_ports and available_ports doesn't change when NodePort are created or deleted.
374+
375+
All metrics mentioned above have been added since v1.27.
376+
372377
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
373378
374379
Since it is a purely in-memory feature the upgrade or downgrande doesn't have any impact.
@@ -463,9 +468,10 @@ N/A
463468
464469
## Implementation History
465470
466-
## Drawbacks
467-
468471
- v1.27 - Initial implementation https://github.com/kubernetes/kubernetes/pull/114418
469472
- v1.28 - Beta
473+
- v1.29 - GA
474+
475+
## Drawbacks
470476
471477
## Alternatives

keps/sig-network/3668-reserved-service-nodeport-range/kep.yaml

+8-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ owning-sig: sig-network
66
participating-sigs:
77
status: implementable
88
creation-date: 2022-11-30
9-
last-updated: 2023-05-05
9+
last-updated: 2023-08-22
1010
reviewers:
1111
approvers:
1212
- "@thockin"
@@ -16,18 +16,18 @@ see-also:
1616
- "/keps/sig-network/3070-reserved-service-ip-range"
1717

1818
# The target maturity stage in the current dev cycle for this KEP.
19-
stage: beta
19+
stage: "stable"
2020

2121
# The most recent milestone for which work toward delivery of this KEP has been
2222
# done. This can be the current (upcoming) milestone, if it is being actively
2323
# worked on.
24-
latest-milestone: "v1.28"
24+
latest-milestone: "v1.29"
2525

2626
# The milestone at which this feature was, or is targeted to be, at each stage.
2727
milestone:
2828
alpha: "v1.27"
2929
beta: "v1.28"
30-
stable: "v1.30"
30+
stable: "v1.29"
3131

3232
# The following PRR answers are required at alpha release
3333
# List the feature gate name and the components for which it must be enabled
@@ -39,3 +39,7 @@ disable-supported: true
3939

4040
# The following PRR answers are required at beta release
4141
metrics:
42+
- kube_apiserver_nodeport_allocator_allocated_ports
43+
- kube_apiserver_nodeport_allocator_available_ports
44+
- kube_apiserver_nodeport_allocator_allocation_total
45+
- kube_apiserver_nodeport_allocator_allocation_errors_total

0 commit comments

Comments
 (0)