Merge pull request #4409 from carlory/kep-3751

update latest-milestone to 1.30 and fix vac definition

Author: k8s-ci-robot

Diff for: keps/sig-storage/3751-volume-attributes-class/README.md

@@ -138,17 +138,23 @@ type VolumeAttributesClass struct {
   // +optional
   metav1.ObjectMeta
 
-  // Spec defines the behavior of a VolumeAttributesClass.
-  // +optional
-  Spec VolumeAttributesClassSpec
-}
-
-type VolumeAttributesClassSpec struct {
-  // Name of the driver
+  // Name of the CSI driver
+  // This field is immutable.
   DriverName string
-  // This field is OPTIONAL.This allows the CO to specify the
-  // volume attributes class parameters to apply. 
-  // These parameters are immutable 
+
+  // parameters hold volume attributes defined by the CSI driver. These values
+  // are opaque to the Kubernetes and are passed directly to the CSI driver.
+  // The underlying storage provider supports changing these attributes on an
+  // existing volume, however the parameters field itself is immutable. To
+  // invoke a volume update, a new VolumeAttributesClass should be created with
+  // new parameters, and the PersistentVolumeClaim should be updated to reference
+  // the new VolumeAttributesClass.
+  // 
+  // This field is required and must contain at least one key/value pair.
+  // The keys cannot be empty, and the maximum number of parameters is 512, with
+  // a cumulative max size of 256K. If the CSI driver rejects invalid parameters,
+  // the target PersistentVolumeClaim will be set to an "Infeasible" state in the
+  // modifyVolumeStatus field.
   Parameters map[string]string
 }
 
@@ -1276,4 +1282,4 @@ More details in Google doc [CSI Spec for ModifyVolume](https://docs.google.com/d
 
 ## Infrastructure Needed (Optional)
 
-Not needed.
+Not needed.

Diff for: keps/sig-storage/3751-volume-attributes-class/kep.yaml

@@ -23,7 +23,7 @@ stage: alpha
 # The most recent milestone for which work toward delivery of this KEP has been
 # done. This can be the current (upcoming) milestone, if it is being actively
 # worked on.
-latest-milestone: "1.29"
+latest-milestone: "1.30"
 
 # The milestone at which this feature was, or is targeted to be, at each stage.
 milestone: