Skip to content

Commit 035ba5c

Browse files
KEP 2371: retarget to alpha for 1.29
Signed-off-by: Sohan Kunkerkar <[email protected]>
1 parent f5fef77 commit 035ba5c

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed
-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
kep-number: 2371
22
alpha:
3-
approver: "@ehashman"
4-
beta:
53
approver: "@deads2k"

keps/sig-node/2371-cri-pod-container-stats/README.md

+6-5
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ Below is a table describing which stats come from what source now, as well a pro
182182
| |N/A |container_last_seen |N/A |cAdvisor |CRI or N/A | now.Now().Unix() | now.Now().Unix()
183183
| | | | |cAdvisor |CRI or N/A |
184184

185+
This KEP was previously targeted at beta in Kubernetes 1.28. However, upon further review, the feature is not yet ready for beta graduation. As such, we are moving the target back to alpha in Kubernetes 1.29 to allow more time to mature the implementation.
185186

186187
## Motivation
187188

@@ -651,9 +652,8 @@ Each compliant CRI implementation must:
651652

652653
Below is the proposed strategy for doing so:
653654

654-
1. The Alpha release will add support for both `/stats/summary` endpoint and `/metrics/cadvisor` endpoint.
655-
2. For the Beta release, add support for CRI implementations to report these metrics
656-
- Initial research on the set of metrics required should be done. This will, possibly, allow the community to declare metrics that are not required to be moved to the CRI implementations.
655+
1. The Alpha release will add support for both `/stats/summary` endpoint and `/metrics/cadvisor` endpoint. The release will focus on finalizing and enabling support for the set of metrics from /metrics/cadvisor that CRI implementations must support.
656+
2. For the Beta release, we will focus on:
657657
- Testing on how performant cAdvisor+Kubelet are today should be done, to find a target, acceptable threshold of performance for the CRI implementations
658658
- Creation of tests verifying the metrics are reported correctly should be created and verified with the existing cAdvisor implementation.
659659
3. For the GA release, the CRI implementation should be the source of truth for all pod and container level metrics that external parties rely on (no matter how many endpoints the Kubelet advertises).
@@ -800,11 +800,11 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
800800
- This new behavior will be gated by a feature gate to prevent regressions for users that rely on the old behavior.
801801
- cAdvisor should be able to optionally not report the metrics needed for both summary API and `/metrics/cadvisor`. This behavior will be toggled by the Kubelet feature gate.
802802
- Kubelet will query the CRI implementation for endpoints to broadcast from its own server.
803-
- This will allow the CRI to broadcast `/metrics/cadvisor` through the Kubelet's HTTP server.
803+
- This will allow the CRI to broadcast `/metrics/cadvisor` through the Kubelet's HTTP server.
804+
- Conduct research to find the set of metrics from `/metrics/cadvisor` that compliant CRI implementations must expose.
804805

805806
#### Alpha -> Beta Graduation
806807

807-
- Conduct research to find the set of metrics from `/metrics/cadvisor` that compliant CRI implementations must expose.
808808
- Conformance tests for the fields in `/metrics/cadvisor` should be created.
809809
- Validate performance impact of this feature is within allowable margin (or non-existent, ideally).
810810
- The CRI stats implementation should perform better than they did with CRI+cAdvisor.
@@ -1070,6 +1070,7 @@ _This section must be completed when targeting beta graduation to a release._
10701070
2022-06-13: Move some Beta criteria to Alpha criteria in 1.25
10711071
2022-12-09: Retarget KEP to alpha in 1.26
10721072
2023-05-19: KEP targeted at Beta in 1.28
1073+
2023-05-19: KEP retargeted to Alpha in 1.29
10731074

10741075
## Drawbacks
10751076

keps/sig-node/2371-cri-pod-container-stats/kep.yaml

+4-5
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,12 @@ reviewers:
1414
approvers:
1515
- "@dchen1107"
1616
creation-date: 2021-01-27
17-
last-updated: 2023-05-19
17+
last-updated: 2023-09-27
1818
status: implementable
19-
stage: beta
20-
latest-milestone: "v1.28"
19+
stage: alpha
20+
latest-milestone: "v1.29"
2121
milestone:
22-
alpha: "v1.23"
23-
beta: "v1.28"
22+
alpha: "v1.29"
2423
see-also:
2524
- N/A
2625
replaces:

0 commit comments

Comments
 (0)