Skip to content

Commit 270cacf

Browse files
committed
update guidance on reviewers teams
1 parent 77666f8 commit 270cacf

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

Diff for: org-owners-guide.md

+6-5
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ Each organization should have the following teams:
5454
- teams for each repo `foo`
5555
- `foo-admins`: granted admin access to the `foo` repo
5656
- `foo-maintainers`: granted write access to the `foo` repo
57+
- `foo-reviewers`: granted read access to the `foo` repo; intended to be used as
58+
a notification mechanism for interested/active contributors for the `foo` repo
5759
- a `bots` team
5860
- should contain bots such as @k8s-ci-robot and @linuxfoundation that are
5961
neccessary for org and repo automation
@@ -66,11 +68,10 @@ Each organization should have the following teams:
6668
We are looking to coalesce existing teams towards this model, and use this model
6769
for all orgs going forward. Notable discrepancies at the moment:
6870

69-
- `foo-reviewers` teams that grant read access to each `foo` repo haven't
70-
proven themselves useful. Reviews are now requested from sigs via
71-
@sig-foo-pr-reviews teams, and read access is already granted to the public
72-
at large. These don't need to be created going forward, and can be removed
73-
if they're not actively being used.
71+
- `foo-reviewers` teams are considered a historical subset of
72+
`kubernetes-sig-foo-pr-reviews` teams and are intended mostly as a fallback
73+
notification mechanism when requested reviewers are being unresponsive. Ideally
74+
OWNERS files can be used in lieu of these teams.
7475
- `admins-foo` and `maintainers-foo` teams as used by the kubernetes-incubator
7576
org. This was a mistake that swapped the usual convention, and we would like
7677
to rename the team

0 commit comments

Comments
 (0)