Skip to content

Commit b76dbf0

Browse files
liggittk8s-publishing-bot
authored andcommitted
Avoid returning nil responseKind in v1beta1 aggregated discovery
Kubernetes-commit: 1876ddf71497bad349f7c4df24c2e22356d3bad9
1 parent 9ab79ea commit b76dbf0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

apidiscovery/v2beta1/generated.proto

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apidiscovery/v2beta1/types.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ type APIResourceDiscovery struct {
9292
Resource string `json:"resource" protobuf:"bytes,1,opt,name=resource"`
9393
// responseKind describes the group, version, and kind of the serialization schema for the object type this endpoint typically returns.
9494
// APIs may return other objects types at their discretion, such as error conditions, requests for alternate representations, or other operation specific behavior.
95-
// This value will be null if an APIService reports subresources but supports no operations on the parent resource
95+
// This value will be null or empty if an APIService reports subresources but supports no operations on the parent resource
9696
ResponseKind *v1.GroupVersionKind `json:"responseKind,omitempty" protobuf:"bytes,2,opt,name=responseKind"`
9797
// scope indicates the scope of a resource, either Cluster or Namespaced
9898
Scope ResourceScope `json:"scope" protobuf:"bytes,3,opt,name=scope"`
@@ -141,7 +141,7 @@ type APISubresourceDiscovery struct {
141141
// for this resource across all versions.
142142
Subresource string `json:"subresource" protobuf:"bytes,1,opt,name=subresource"`
143143
// responseKind describes the group, version, and kind of the serialization schema for the object type this endpoint typically returns.
144-
// Some subresources do not return normal resources, these will have null return types.
144+
// Some subresources do not return normal resources, these will have null or empty return types.
145145
ResponseKind *v1.GroupVersionKind `json:"responseKind,omitempty" protobuf:"bytes,2,opt,name=responseKind"`
146146
// acceptedTypes describes the kinds that this endpoint accepts.
147147
// Subresources may accept the standard content types or define

0 commit comments

Comments
 (0)