[KEP-4817] Add limits on conditions and IPs + fix documentation

Signed-off-by: Lionel Jouin <[email protected]>

Kubernetes-commit: 118356175d234d65efe28368cc896cef4f23d238

Author: LionelJouin

Diff for: resource/v1alpha3/types.go

@@ -1032,11 +1032,14 @@ type AllocatedDeviceStatus struct {
 	// config references, the `Ready` condition should be True.
 	//
 	// +optional
-	// +listType=atomic
+	// +listType=map
+	// +listMapKey=type
 	Conditions []metav1.Condition `json:"conditions" protobuf:"bytes,4,opt,name=conditions"`
 
 	// Data contains arbitrary driver-specific data.
 	//
+	// The length of the raw data must be smaller or equal to 10 Ki.
+	//
 	// +optional
 	Data runtime.RawExtension `json:"data,omitempty" protobuf:"bytes,5,opt,name=data"`
 
@@ -1052,7 +1055,9 @@ type AllocatedDeviceStatus struct {
 type NetworkDeviceData struct {
 	// InterfaceName specifies the name of the network interface associated with
 	// the allocated device. This might be the name of a physical or virtual
-	// network interface.
+	// network interface being configured in the pod.
+	//
+	// Must not be longer than 256 characters.
 	//
 	// +optional
 	InterfaceName string `json:"interfaceName,omitempty" protobuf:"bytes,1,opt,name=interfaceName"`
@@ -1069,6 +1074,8 @@ type NetworkDeviceData struct {
 
 	// HardwareAddress represents the hardware address (e.g. MAC Address) of the device's network interface.
 	//
+	// Must not be longer than 128 characters.
+	//
 	// +optional
 	HardwareAddress string `json:"hardwareAddress,omitempty" protobuf:"bytes,3,opt,name=hardwareAddress"`
 }

Diff for: resource/v1beta1/types.go

@@ -1035,11 +1035,14 @@ type AllocatedDeviceStatus struct {
 	// config references, the `Ready` condition should be True.
 	//
 	// +optional
-	// +listType=atomic
+	// +listType=map
+	// +listMapKey=type
 	Conditions []metav1.Condition `json:"conditions" protobuf:"bytes,4,opt,name=conditions"`
 
 	// Data contains arbitrary driver-specific data.
 	//
+	// The length of the raw data must be smaller or equal to 10 Ki.
+	//
 	// +optional
 	Data runtime.RawExtension `json:"data,omitempty" protobuf:"bytes,5,opt,name=data"`
 
@@ -1055,7 +1058,9 @@ type AllocatedDeviceStatus struct {
 type NetworkDeviceData struct {
 	// InterfaceName specifies the name of the network interface associated with
 	// the allocated device. This might be the name of a physical or virtual
-	// network interface.
+	// network interface being configured in the pod.
+	//
+	// Must not be longer than 256 characters.
 	//
 	// +optional
 	InterfaceName string `json:"interfaceName,omitempty" protobuf:"bytes,1,opt,name=interfaceName"`
@@ -1072,6 +1077,8 @@ type NetworkDeviceData struct {
 
 	// HardwareAddress represents the hardware address (e.g. MAC Address) of the device's network interface.
 	//
+	// Must not be longer than 128 characters.
+	//
 	// +optional
 	HardwareAddress string `json:"hardwareAddress,omitempty" protobuf:"bytes,3,opt,name=hardwareAddress"`
 }