Skip to content

error "non-constant format string" with go 1.24 #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yongruilin opened this issue Feb 1, 2025 · 1 comment · Fixed by #282
Closed

error "non-constant format string" with go 1.24 #281

yongruilin opened this issue Feb 1, 2025 · 1 comment · Fixed by #282
Assignees
@yongruilin

Comments

@yongruilin
Copy link
Contributor

When trying to run test locally but got error

# sigs.k8s.io/structured-merge-diff/v4/typed
typed/validate.go:160:17: non-constant format string in call to sigs.k8s.io/structured-merge-diff/v4/typed.errorf
typed/validate.go:196:17: non-constant format string in call to sigs.k8s.io/structured-merge-diff/v4/typed.errorf
FAIL    sigs.k8s.io/structured-merge-diff/v4/typed [build failed]

This is due to the update in go 1.24 golang/go#60529

Need to update the error return to address.

Ref:
@yongruilin yongruilin mentioned this issue Feb 1, 2025
Merged
@yongruilin
Copy link
Contributor Author

/assign

@sebrandon1 sebrandon1 mentioned this issue Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yongruilin yongruilin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update error formatting and test naming yongruilin/structured-merge-diff
1 participant
@yongruilin