test path element less

Author: lavalamp

fieldpath/element_test.go

@@ -18,6 +18,8 @@ package fieldpath
 
 import (
 	"testing"
+
+	"sigs.k8s.io/structured-merge-diff/value"
 )
 
 func TestPathElementSet(t *testing.T) {
@@ -59,3 +61,111 @@ func TestPathElementSet(t *testing.T) {
 		i++
 	})
 }
+
+func strptr(s string) *string   { return &s }
+func intptr(i int) *int         { return &i }
+func valptr(i int) *value.Value { v := value.IntValue(i); return &v }
+
+func TestPathElementLess(t *testing.T) {
+	table := []struct {
+		name string
+		// we expect a < b and !(b < a) unless eq is true, in which
+		// case we expect less to return false in both orders.
+		a, b PathElement
+		eq   bool
+	}{
+		{
+			name: "FieldName-0",
+			a:    PathElement{},
+			b:    PathElement{},
+			eq:   true,
+		}, {
+			name: "FieldName-1",
+			a:    PathElement{FieldName: strptr("anteater")},
+			b:    PathElement{FieldName: strptr("zebra")},
+		}, {
+			name: "FieldName-2",
+			a:    PathElement{FieldName: strptr("bee")},
+			b:    PathElement{FieldName: strptr("bee")},
+			eq:   true,
+		}, {
+			name: "FieldName-3",
+			a:    PathElement{FieldName: strptr("capybara")},
+			b:    PathElement{Key: []value.Field{{Name: "dog", Value: value.IntValue(3)}}},
+		}, {
+			name: "FieldName-4",
+			a:    PathElement{FieldName: strptr("elephant")},
+			b:    PathElement{Value: valptr(4)},
+		}, {
+			name: "FieldName-5",
+			a:    PathElement{FieldName: strptr("falcon")},
+			b:    PathElement{Index: intptr(5)},
+		}, {
+			name: "Key-1",
+			a:    PathElement{Key: []value.Field{{Name: "goat", Value: value.IntValue(1)}}},
+			b:    PathElement{Key: []value.Field{{Name: "goat", Value: value.IntValue(1)}}},
+			eq:   true,
+		}, {
+			name: "Key-2",
+			a:    PathElement{Key: []value.Field{{Name: "horse", Value: value.IntValue(1)}}},
+			b:    PathElement{Key: []value.Field{{Name: "horse", Value: value.IntValue(2)}}},
+		}, {
+			name: "Key-3",
+			a:    PathElement{Key: []value.Field{{Name: "ibex", Value: value.IntValue(1)}}},
+			b:    PathElement{Key: []value.Field{{Name: "jay", Value: value.IntValue(1)}}},
+		}, {
+			name: "Key-4",
+			a:    PathElement{Key: []value.Field{{Name: "kite", Value: value.IntValue(1)}}},
+			b:    PathElement{Key: []value.Field{{Name: "kite", Value: value.IntValue(1)}, {Name: "kite-2", Value: value.IntValue(1)}}},
+		}, {
+			name: "Key-5",
+			a:    PathElement{Key: []value.Field{{Name: "kite", Value: value.IntValue(1)}}},
+			b:    PathElement{Value: valptr(1)},
+		}, {
+			name: "Key-6",
+			a:    PathElement{Key: []value.Field{{Name: "kite", Value: value.IntValue(1)}}},
+			b:    PathElement{Index: intptr(5)},
+		}, {
+			name: "Value-1",
+			a:    PathElement{Value: valptr(1)},
+			b:    PathElement{Value: valptr(2)},
+		}, {
+			name: "Value-2",
+			a:    PathElement{Value: valptr(1)},
+			b:    PathElement{Value: valptr(1)},
+			eq:   true,
+		}, {
+			name: "Value-3",
+			a:    PathElement{Value: valptr(1)},
+			b:    PathElement{Index: intptr(1)},
+		}, {
+			name: "Index-1",
+			a:    PathElement{Index: intptr(1)},
+			b:    PathElement{Index: intptr(2)},
+		}, {
+			name: "Index-2",
+			a:    PathElement{Index: intptr(1)},
+			b:    PathElement{Index: intptr(1)},
+			eq:   true,
+		},
+	}
+
+	for i := range table {
+		i := i
+		t.Run(table[i].name, func(t *testing.T) {
+			tt := table[i]
+			if tt.eq {
+				if tt.a.Less(tt.b) {
+					t.Errorf("oops, a < b: %#v, %#v", tt.a, tt.b)
+				}
+			} else {
+				if !tt.a.Less(tt.b) {
+					t.Errorf("oops, a >= b: %#v, %#v", tt.a, tt.b)
+				}
+			}
+			if tt.b.Less(tt.b) {
+				t.Errorf("oops, b < a: %#v, %#v", tt.b, tt.a)
+			}
+		})
+	}
+}