Enable all the e2e tests in Windows

Author: mauriciopoppe

hack/e2e.sh

@@ -142,7 +142,7 @@ CLUSTER=${CLUSTER:-e2e}
 GKE_ENVIRONMENT=${GKE_ENVIRONMENT:-prod}
 KUBERNETES_SRC=${KUBERNETES_SRC:-} # If set, skip extracting kubernetes, use it as kubernetes src.
 KIND_NODE_IMAGE=${KIND_NODE_IMAGE:-} # Prebuilt kind node image to use, e.g. kindest/node:v1.15.0.
-# set from kubernetes/test-infra
+# set in the prow job through the common config in kubernetes/test-infra
 GOOGLE_APPLICATION_CREDENTIALS=${GOOGLE_APPLICATION_CREDENTIALS:-}
 JENKINS_GCE_SSH_PRIVATE_KEY_FILE=${JENKINS_GCE_SSH_PRIVATE_KEY_FILE:-}
 JENKINS_GCE_SSH_PUBLIC_KEY_FILE=${JENKINS_GCE_SSH_PUBLIC_KEY_FILE:-}
@@ -166,9 +166,6 @@ echo "DEPLOYMENT: $DEPLOYMENT" >&2
 echo "CLUSTER: $CLUSTER" >&2
 echo "GKE_ENVIRONMENT: $GKE_ENVIRONMENT" >&2
 echo "KUBERNETES_SRC: $KUBERNETES_SRC" >&2
-echo "GOOGLE_APPLICATION_CREDENTIALS: $GOOGLE_APPLICATION_CREDENTIALS" >&2
-echo "JENKINS_GCE_SSH_PRIVATE_KEY_FILE: $JENKINS_GCE_SSH_PRIVATE_KEY_FILE" >&2
-echo "JENKINS_GCE_SSH_PUBLIC_KEY_FILE: $JENKINS_GCE_SSH_PUBLIC_KEY_FILE" >&2
 
 kubetest_args=(
     --provider "$PROVIDER"
@@ -209,6 +206,8 @@ if [ "$PROVIDER" == "gce" -o "$PROVIDER" == "gke" ]; then
         kubetest_args+=(
             --gcp-zone "$GCP_ZONE"
         )
+        # also set the default zone for the gcloud sdk
+        export CLOUDSDK_COMPUTE_ZONE="$GCP_ZONE"
     fi
 
     if [ -n "$GOOGLE_APPLICATION_CREDENTIALS" ]; then
@@ -323,9 +322,9 @@ if [ "$PROVIDER" == "gke" ]; then
 fi
 
 # legacy path
-    # --up
-    # --down
 go run $ROOT/hack/e2e.go -- "${kubetest_args[@]}" \
     --deployment="$DEPLOYMENT" \
+    --up \
+    --down \
     --test-cmd="$ROOT/hack/run-e2e.sh" \
     "${@:-}"

hack/run-e2e.sh

@@ -84,7 +84,7 @@ fi
 if [ -z "$PROVISIONER_E2E_IMAGE" ]; then
     # build and push ${version}_linux_amd64 and ${version}_windows_ltsc2019
     VERSION=${VERSION:-$(git describe --tags --abbrev=8 --always)}
-    REGISTRY=${REGISTRY:-k8s.gcr.io/sig-storage}
+    REGISTRY=${REGISTRY:-gcr.io/${PROJECT}}
     IMAGE=local-volume-provisioner
 
     REGISTRY=${REGISTRY} \
@@ -133,13 +133,14 @@ fi
 export PROVISIONER_IMAGE_NAME
 export PROVISIONER_IMAGE_PULL_POLICY
 
+# Taint nodes of the platform where the test shouldn't run
 current_platform=linux
 taint_platform=windows
 if [ "${KUBERNETES_NODE_PLATFORM}" == "windows" ]; then
     current_platform=windows
     taint_platform=linux
 fi
-echo "Running tests for platform=${current_platform}, removing taints from all nodes and tainting platform=${taint_platform} nodes"
+echo "Running tests for platform=${current_platform}, tainting platform=${taint_platform} nodes"
 kubectl get nodes -o name | \
 while IFS= read -r node; do
   kubectl taint node $node node.kubernetes.io/os:NoSchedule- || true

helm/generated_examples/helm2/gke-mauricio.yaml

@@ -329,8 +329,8 @@ func ConfigMapDataToVolumeConfig(data map[string]string, provisionerConfig *Prov
 		if config.MountDir == "" || config.HostDir == "" {
 			return fmt.Errorf("Storage Class %v is misconfigured, missing HostDir or MountDir parameter", class)
 		}
-		config.MountDir = normalizePath(config.MountDir)
-		config.HostDir = normalizePath(config.HostDir)
+		config.MountDir = NormalizePath(config.MountDir)
+		config.HostDir = NormalizePath(config.HostDir)
 
 		if config.VolumeMode == "" {
 			config.VolumeMode = DefaultVolumeMode
@@ -357,10 +357,10 @@ func ConfigMapDataToVolumeConfig(data map[string]string, provisionerConfig *Prov
 	return nil
 }
 
-// normalizePath makes sure the given path is a valid path on Windows too
+// NormalizePath makes sure the given path is a valid path on Windows too
 // by making sure all instances of `/` are replaced with `\\`, and the
 // path beings with `c:`
-func normalizePath(path string) string {
+func NormalizePath(path string) string {
 	if runtime.GOOS != "windows" {
 		return path
 	}

pkg/common/common.go

@@ -119,7 +119,4 @@ func StartLocalController(client *kubernetes.Clientset, ptable deleter.ProcTable
 		discoverer.DiscoverLocalVolumes()
 		time.Sleep(discoveryPeriod)
 	}
-
-	// unreachable
-	return nil
 }