Skip to content

Import scheduler_perf from Kubernetes repository rather than maintaining a copy #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sanposhiho opened this issue Jan 14, 2024 · 15 comments · May be fixed by #135
Open

Import scheduler_perf from Kubernetes repository rather than maintaining a copy #94

sanposhiho opened this issue Jan 14, 2024 · 15 comments · May be fixed by #135
Assignees
@saku3
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@sanposhiho
Copy link
Member

We have a performance test for our scheduler in https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/tree/main/internal/e2e/scheduler_perf.

The scheduler_perf is importable now, we no longer need to maintain the copy.
kubernetes/kubernetes#119079

/kind cleanup
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 14, 2024
@utam0k
Copy link
Member

utam0k commented Jan 14, 2024

Can I give it a try?

@sanposhiho
Copy link
Member Author

sanposhiho commented Jan 14, 2024 •
edited
Loading

Yes, but we probably have to wait for a release of k/k?

@sanposhiho
Copy link
Member Author

/assign @utam0k
(but after v1.30)

@utam0k
Copy link
Member

utam0k commented Apr 28, 2024

It's time to bump up to K1.30. I'm trying it...

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2024
@sanposhiho
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2024
@utam0k
Copy link
Member

utam0k commented Jul 28, 2024

I am working on it, but it is taking time.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 26, 2024
@bells17
Copy link

bells17 commented Oct 30, 2024

If it’s okay for it to take a little time, may I give it a try?

@sanposhiho
Copy link
Member Author

I'm ok, if @utam0k is ok to pass it over.

@utam0k
Copy link
Member

utam0k commented Oct 30, 2024

Sure, please take it over. Updating k8s was difficult for me.

@utam0k utam0k removed their assignment Oct 30, 2024
@sanposhiho
Copy link
Member Author

/assign @bells17

@sanposhiho sanposhiho mentioned this issue Nov 4, 2024
Closed
@sanposhiho
Copy link
Member Author

#128 upgrades k/k.

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2024
@saku3 saku3 linked a pull request Feb 8, 2025 that will close this issue
Open
@saku3
Copy link

saku3 commented Feb 8, 2025

I spoke directly with @bells17 and took over this issue.

@sanposhiho
Copy link
Member Author

/unassign @bells17
/assign @saku3

@k8s-ci-robot k8s-ci-robot assigned saku3 and unassigned bells17 Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saku3 saku3

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Import scheduler_perf from Kubernetes repository saku3/kube-scheduler-wasm-extension
6 participants
@bells17 @utam0k @k8s-ci-robot @saku3 @sanposhiho @k8s-triage-robot