Skip to content

Unit tests for Node #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidz627 opened this issue Jul 3, 2018 · 6 comments
Closed

Unit tests for Node #48

davidz627 opened this issue Jul 3, 2018 · 6 comments
Labels
kind/test Categorizes issue or PR as related to testing lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone
GA

Comments

@davidz627
Copy link
Contributor

No description provided.

@davidz627 davidz627 added the kind/test Categorizes issue or PR as related to testing label Jul 3, 2018
@davidz627 davidz627 added this to the Beta milestone Jul 3, 2018
@davidz627 davidz627 mentioned this issue Jul 3, 2018
Closed
@davidz627 davidz627 mentioned this issue Jul 26, 2018
Merged
@davidz627 davidz627 modified the milestones: Beta, GA Sep 26, 2018
@Mockery-Li
Copy link
Contributor

Hi, I have added unit test for GetNodeInfo in issue#19, and hope to complete other unit tests for Node.
Is there any sample for testing the mounter?

@davidz627
Copy link
Contributor Author

@Mockery-Li you may be able to find some examples in the existing k8s code: https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/gcepd/gce_pd_test.go#L129
^ I'm not really sure if this is what you're looking for but it might be a good starting point

@msau42
Copy link
Contributor

msau42 commented Apr 15, 2019

For mounter, we usually use the FakeMounter for testing.

@Mockery-Li
Copy link
Contributor

Thanks, that's what I need

@Mockery-Li Mockery-Li mentioned this issue Apr 19, 2019
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2019
@davidz627
Copy link
Contributor Author

Closed by #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/test Categorizes issue or PR as related to testing lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
GA
Development

No branches or pull requests
5 participants
@davidz627 @k8s-ci-robot @msau42 @fejta-bot @Mockery-Li